-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload packages to PyPI #8
Merged
leandro-lucarella-frequenz
merged 7 commits into
frequenz-floss:v0.x.x
from
leandro-lucarella-frequenz:pypi
Sep 5, 2022
Merged
Upload packages to PyPI #8
leandro-lucarella-frequenz
merged 7 commits into
frequenz-floss:v0.x.x
from
leandro-lucarella-frequenz:pypi
Sep 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandro-lucarella-frequenz
added
part:tooling
Affects the development tooling (CI, deployment, dependency management, etc.)
type:enhancement
New feature or enhancement visitble to users
labels
Sep 1, 2022
github-actions
bot
added
part:docs
Affects the documentation
part:python
Affects the Python bindings
labels
Sep 1, 2022
Closed
The source distribution of the package doesn't need those files. Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
This cleans up the setup.py file to only have the build hook to compile the proto files. Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
Add the following configuration keys to have more complete and descriptive metadata: * readme * keywords * classifiers * project.authors.email * project.urls Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
Now proto files can be compiled via `setup.py compile_proto`. This removes the dependency on shell scripts, which helps with portability. Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
Release is triggered on creating GitHub releases, as well as updating, etc. We generally don't want to re-run the CI if there are no code changes. Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
I already tested this in my fork, here are the produced packages: https://pypi.org/project/frequenz-api-microgrid/#history (these are tags I created in my forks for testing purposes). |
Add steps to publish distribution files to PyPI when a tag is created. We also split the step of building the package distribution as we don't need to do that for every Python version, so there is no much use to have it inside a matrix. This also parallelize jobs as much as possible, so protolint, tests and building the distribution packages are done in parallel. Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
I added one commit to update to the new repository name. |
tiyash-basu-frequenz
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
part:docs
Affects the documentation
part:python
Affects the Python bindings
part:tooling
Affects the development tooling (CI, deployment, dependency management, etc.)
type:enhancement
New feature or enhancement visitble to users
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a bit of cleanup and modernization of the project and upload
packages to PyPI when new tags are pushed.