Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bidirectional #234

Closed
llucax opened this issue Nov 6, 2023 · 0 comments · Fixed by #235
Closed

Remove Bidirectional #234

llucax opened this issue Nov 6, 2023 · 0 comments · Fixed by #235
Labels
part:channels Affects channels implementation scope:breaking-change Breaking change, users will need to update their code type:enhancement New feature or enhancement visitble to users
Milestone

Comments

@llucax
Copy link
Contributor

llucax commented Nov 6, 2023

What's needed?

Using bidirectional channels is not a recommended practice and should not be encouraged by this library.

Proposed solution

Remove Bidirectional.

Use cases

No response

Alternatives and workarounds

No response

Additional context

No response

@llucax llucax added type:enhancement New feature or enhancement visitble to users part:channels Affects channels implementation scope:breaking-change Breaking change, users will need to update their code labels Nov 6, 2023
@llucax llucax added this to the v1.0.0 milestone Nov 6, 2023
github-merge-queue bot pushed a commit that referenced this issue Nov 9, 2023
- Remove `Bidirectional` channel
- Remove `Peekable` and associated methods/classes
- Don't import `TypeVar`s from other modules
- Make all `TypeVar`s private
- Split `_base_classes` into `_receiver` and `_sender`
- Make channels return the base sender and receiver types
- Make channel's sender and receiver implementation private
- Don't use aliases for the base sender and receiver classes
- Move merge and select symbols to the top level
- Move utility receivers to their own public modules
- Move nested class out of the parent class

Fixes #233, fixes #234.
@llucax llucax modified the milestones: v1.0.0, v1.0.0-rc.1 Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:channels Affects channels implementation scope:breaking-change Breaking change, users will need to update their code type:enhancement New feature or enhancement visitble to users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant