Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make resend_latest a public attribute for Broadcast channels #221

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

shsms
Copy link
Contributor

@shsms shsms commented Oct 25, 2023

This allows modifying the flag after the channel is constructed, for
example in dynamically created channels.

This allows modifying the flag after the channel is constructed, for
example in dynamically created channels.

Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@shsms shsms requested a review from a team as a code owner October 25, 2023 14:46
@shsms shsms requested a review from Marenz October 25, 2023 14:46
@github-actions github-actions bot added the part:channels Affects channels implementation label Oct 25, 2023
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@github-actions github-actions bot added the part:docs Affects the documentation label Oct 25, 2023
Copy link
Contributor

@daniel-zullo-frequenz daniel-zullo-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an optional suggestion to check for and LGTM

Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@shsms shsms added this pull request to the merge queue Oct 26, 2023
Merged via the queue into frequenz-floss:v0.x.x with commit 40ab70c Oct 26, 2023
9 checks passed
@shsms shsms deleted the resend_latest branch October 26, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:channels Affects channels implementation part:docs Affects the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants