Report the type of change observed in FileWatcher #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
daniel-zullo-frequenz
force-pushed
the
feature/report-type-change-file-watcher
branch
2 times, most recently
from
825baca
to
6754e71
Compare
|
Updated based on a couple of suggestions from Luca. |
To gradually get rid of the former typing. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
daniel-zullo-frequenz
force-pushed
the
feature/report-type-change-file-watcher
branch
3 times, most recently
from
8e8bf93
to
d3445a1
Compare
|
Updated based on latest suggestions from Luca |
leandro-lucarella-frequenz
previously approved these changes
May 10, 2023
daniel-zullo-frequenz
force-pushed
the
feature/report-type-change-file-watcher
branch
from
b98f075
to
fa9eb8d
Compare
|
@leandro-lucarella-frequenz I added a trivial fix to correct typos and format in the releases notes (not related to this PR). Can you please check it and re-approve it if LGTY? |
leandro-lucarella-frequenz
previously approved these changes
May 11, 2023
Marenz
reviewed
May 11, 2023
daniel-zullo-frequenz
force-pushed
the
feature/report-type-change-file-watcher
branch
from
fa9eb8d
to
9477555
Compare
Previously, the FileWatcher only provided information of the path of the changed file, without indicating whether the change was a creation, modification, or deletion. This commit improves the functionality of the FileWatcher by adding the ability to report the type of change observed. This additional information can be useful when tracking changes to files and understanding the context of the change. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
daniel-zullo-frequenz
force-pushed
the
feature/report-type-change-file-watcher
branch
from
9477555
to
7469704
Compare
Marenz
reviewed
May 11, 2023
leandro-lucarella-frequenz
approved these changes
May 11, 2023
There was a problem hiding this comment.
Besides agreeing to @Marenz suggestion, for me it is fine if it's left for a different PR so we can merge this sooner than later, as it is out of the scope of this PR.
Ok, I'll merge this PR as it currently is and create an issue to address #87 (comment) |
daniel-zullo-frequenz
merged commit 7fd8e46
into
frequenz-floss:v0.x.x
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the FileWatcher only provided information on the path of the changed file, without indicating whether the change was a creation, modification, or deletion. This commit improves the functionality of the FileWatcher by adding the ability to report the type of change observed. This additional information can be useful when tracking changes to files and understanding the context of the change.
Fixes #53