[Experiment] Synchronous send() #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:actor
mathias-baumann-frequenz
force-pushed
the
sync_send
branch
from
b31c896
to
f098de4
Compare
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
When the senders closed the channels, the datasourcing actor will also close its sending channels. Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
mathias-baumann-frequenz
force-pushed
the
sync_send
branch
from
f098de4
to
ffbff83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries together with frequenz-floss/frequenz-channels-python#75 to make
sender.send()synchronous.It contains a few commits of my active PRs, but the main part are the changes in all the SDK to make the tests and existing code work when
send()is synchronous.See the last 2 commits.
Motivation for this: Code simplicity and speed. In my benchmark, it changed the throughput from
30k/sto80k/s.You should be able to run the benchmark when you have checked out this branch using
PYTHONPATH=. python benchmarks/timeseries/benchmark_datasourcing.py 15 1000 # 15 evcs, 1000 msgs per bat.This is to be seen as an experiment/prototype PR to test this idea. Feel free to check it out and find errors.
Locally, with the correct channels changes, all tests succeed for me.
Note that you need the channel changes as well for this to work