Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are themes with black background for viewing the music #2

Open
papioara opened this issue Aug 30, 2019 · 4 comments
Open

There are themes with black background for viewing the music #2

papioara opened this issue Aug 30, 2019 · 4 comments

Comments

@papioara
Copy link

I have taken a look at a couple of themes in my Frescobaldi and basically like them, but the ones I have looked at (not all of them have this, and I have not checked every single one) have a black background for viewing the music. This is obviously not very effective if your notes are black, too. It can be changed, of course, in the Frescobaldi settings, but it would be better if none of the themes came with a black background for the music viewer.

@uliska
Copy link
Collaborator

uliska commented Aug 30, 2019 via email

@rkubosz
Copy link
Collaborator

rkubosz commented Aug 30, 2019

have a black background for viewing the music.

Most probably to solve this I have to rearrange color reference in default.mustache file. But to be sure that this is it, please give me the theme title so I could look into this.

@rkubosz
Copy link
Collaborator

rkubosz commented Aug 30, 2019

In `default.mustache' this line (17):

<paper color="#{{base07-hex}}" />

looks correct according to base16's styling guide:

base07 - Light Background (Not often used)

If this problem occurs with a few number of themes, it is most probably that the issue lies upstream in these certain themes (not following the styling guidelines).

A list of themes used in frescobaldi-themes is availabe at https://github.com/chriskempson/base16/blob/master/README.md.

But to be sure, please give me the theme name. I will review it.

@rkubosz
Copy link
Collaborator

rkubosz commented Aug 30, 2019

I've changed the color reference in template and regenerated theme files: #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants