-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There are themes with black background for viewing the music #2
Comments
Which ones have that? What OS? Which Desktop Envirpnment (if applicable)?
Am 30. August 2019 12:22:12 MESZ schrieb papioara <notifications@github.com>:
…I have taken a look at a couple of themes in my Frescobaldi and
basically like them, but the ones I have looked at (not all of them
have this, and I have not checked every single one) have a black
background for viewing the music. This is obviously not very effective
if your notes are black, too. It can be changed, of course, in the
Frescobaldi settings, but it would be better if none of the themes came
with a black background for the music viewer.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#2
--
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
|
Most probably to solve this I have to rearrange color reference in default.mustache file. But to be sure that this is it, please give me the theme title so I could look into this. |
In `default.mustache' this line (17):
looks correct according to base16's styling guide:
If this problem occurs with a few number of themes, it is most probably that the issue lies upstream in these certain themes (not following the styling guidelines). A list of themes used in frescobaldi-themes is availabe at https://github.com/chriskempson/base16/blob/master/README.md. But to be sure, please give me the theme name. I will review it. |
I've changed the color reference in template and regenerated theme files: #3 |
I have taken a look at a couple of themes in my Frescobaldi and basically like them, but the ones I have looked at (not all of them have this, and I have not checked every single one) have a black background for viewing the music. This is obviously not very effective if your notes are black, too. It can be changed, of course, in the Frescobaldi settings, but it would be better if none of the themes came with a black background for the music viewer.
The text was updated successfully, but these errors were encountered: