Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.0 build/dmg for Mac OS X #986

Closed
msikma opened this issue Jul 17, 2017 · 70 comments
Closed

3.0.0 build/dmg for Mac OS X #986

msikma opened this issue Jul 17, 2017 · 70 comments
Assignees
Labels

Comments

@msikma
Copy link

msikma commented Jul 17, 2017

As far as I can see, there is currently no 3.0.0 dmg for Mac OS X. The latest is 2.20.0. Are there any plans for a dmg for OSX, or is there possibly a problem preventing it from being built?

@dliessi dliessi added the macOS label Jul 17, 2017
@dliessi
Copy link
Collaborator

dliessi commented Jul 17, 2017

There is a plan for a Frescobaldi 3 build for macOS, but I've been unable to solve all the issues I'm having in making version 3 work on macOS.

I'm on a trip this week. When I'm back I'll try to fix the remaining problems or open corresponding issues here on GitHub.

@dliessi dliessi self-assigned this Jul 17, 2017
@msikma
Copy link
Author

msikma commented Jul 17, 2017

Thanks for the quick response! I'm really glad you're planning to work on this. Wish I could be of some help. I can build for OSX but I doubt I'd be much use in tracking down whatever last bugs there are...

@wkechel
Copy link

wkechel commented Oct 18, 2017

Are there any news on this issue. I am trying to install frescobaldi via homebrew on high sierra but get the error message:
Error: No available formula with the name "frescobaldi"
==> Searching for a previously deleted formula...
Warning: homebrew/core is shallow clone. To get complete history run:
git -C "$(brew --repo homebrew/core)" fetch --unshallow

frescobaldi was deleted from homebrew/core in commit 4113ec559:
frescobaldi: migrate to boneyard (Homebrew/homebrew-core#5715)

To show the formula before removal run:
git -C "$(brew --repo homebrew/core)" show 4113ec559^:Formula/frescobaldi.rb

If you still use this formula consider creating your own tap:
https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap.html

Since I do not know how to do this situation I am looking for a dmg-file for 3.x

@marnen
Copy link
Contributor

marnen commented Oct 24, 2017

@wkechel Don't use the Homebrew formula for Frescobaldi; I've stopped maintaining it since a native Mac app is now available. Frescobaldi 2.20 is available as a cask. I will update the cask for 3.0 when a Mac build is available.

@dliessi Any further word on a Mac build of 3.0? Can I help somehow?

@sysadm-prs-de
Copy link

Thanks for the hint. I am currently using the 2.x standalone version. Just got the idea to update when I detected the new version. I appreciate any news concerning osx.

@marnen
Copy link
Contributor

marnen commented Oct 24, 2017

I should also say that if it looks like an Aqua build of 3.0.0 will be delayed much longer, I'm willing to resuscitate and update the Homebrew formula. But I hope I won't have to.

@msikma
Copy link
Author

msikma commented Oct 24, 2017

Having some documentation on what the problems are for making a build would be nice. Maybe they are just things that come up naturally during compiling? (Haven't tried it myself yet.) But if they are non-obvious it might be worth having separate issues for others to look at and maybe send in a PR for.

@marnen
Copy link
Contributor

marnen commented Nov 20, 2017

What are the current problems with the Mac build? This issue has been open for months. How can I help?

@sysadm-prs-de
Copy link

I can provide help for the mac port as well, but currently I have no clue how th ebuild process looks like and what is missing. Can anybody give directions?

@dliessi
Copy link
Collaborator

dliessi commented Nov 28, 2017

I'm sorry for not even answering for so long.
I'm working again on this issue and I'll report on it later.

@dliessi
Copy link
Collaborator

dliessi commented Nov 28, 2017

Ok, I had a look at the current situation.
I'm able to run Frescobaldi and most things seem to work.

The most notable thing that is currently not working is the insertion of snippets and templates from the menus, while using the keyboard shortcuts or the snippet manager seems to work correctly.
There are also some minor graphical glitches, such as the file name being cut in the tab label.
I remember that some months ago there were problems in displaying the icons in menus, but they seem to have disappeared with some update in either Qt5 or PyQt5.

Overall the application is quite usable.
If there is an interest, I may provide a prebuilt application bundle for you to test, while I work on the mentioned issues.

@wkechel
Copy link

wkechel commented Nov 29, 2017

Yes, I am interested and I can test. Please let me know when you are ready.

@marnen
Copy link
Contributor

marnen commented Nov 29, 2017

I can also test a Mac build (or attempt to produce one...).

@marnen
Copy link
Contributor

marnen commented Nov 30, 2017

@dliessi How are you dealing with installing python-poppler-qt5? When I try, I run into frescobaldi/python-poppler-qt5#14.

@marnen
Copy link
Contributor

marnen commented Nov 30, 2017

@dliessi:

The most notable thing that is currently not working is the insertion of snippets and templates from the menus, while using the keyboard shortcuts or the snippet manager seems to work correctly.
There are also some minor graphical glitches, such as the file name being cut in the tab label.

Confirmed all of these on Mac OS 10.12 (Sierra) with Python 3.6.3. Oy.

@dliessi
Copy link
Collaborator

dliessi commented Nov 30, 2017

I build python-poppler-qt5 with MacPorts.
I had to backport frescobaldi/python-poppler-qt5@faf4d13 and frescobaldi/python-poppler-qt5#19.
See https://github.com/macports/macports-ports/tree/master/python/py-poppler-qt5 for the current status and macports/macports-ports#1063 for the latest pending update.

@marnen
Copy link
Contributor

marnen commented Nov 30, 2017

@dliessi All right, then we need to figure out a build process that doesn't require the disaster that is MacPorts. I suppose I could make a Homebrew package for python-poppler-qt5.

@marnen
Copy link
Contributor

marnen commented Nov 30, 2017

Actually, some of the suggestions on frescobaldi/python-poppler-qt5#14 are worth a try first. But even before that, I'd like to get the other issues dealt with...

@mojca
Copy link

mojca commented Dec 5, 2017

@dliessi: the MacPorts dependencies are now up to date, so you can submit frescobaldi update once you have it available.

@dliessi
Copy link
Collaborator

dliessi commented Dec 21, 2017

I've been trying to build an application bundle for Frescobaldi 3, but I cannot make py2app work with it as it works with Frescobaldi 2.
Before spending more time on this, I'm going to work on a Portfile for Frescobaldi 3, so that it can be installed via MacPorts.
Only then I'll resume the work on the standalone application bundle.

@marnen
Copy link
Contributor

marnen commented Dec 21, 2017

@dliessi Thank you again for all your work on this. I submit that developing a Portfile is somewhat a waste of time, since very few people are still using MacPorts AFAIK. But of course we can always translate it to a Homebrew formula...

However, I suppose that's a nitpick. The larger issue: what is py2app doing or not doing at the moment? Just saying that you "can't make it work" isn't all that useful; if you describe what's going on in more detail, perhaps others can help.

@dliessi
Copy link
Collaborator

dliessi commented Dec 21, 2017

There weren't many details I could provide: py2app produced an application apparently without errors, but which crashed on startup.
However, while trying to be more specific and investigate the issue in more detail, I noticed I had left out a step in producing the application bundle (i.e., manually copying the Qt5 SVG library file inside the application bundle before running macdeployqt on it), and that was indeed a key step since I now seem to be closer to a working application bundle.
OK, I reversed my priority list again and I'll spend more time on the application bundle today. :)

@mojca
Copy link

mojca commented Dec 21, 2017

@marnen: as far as I'm concerned spending any time on Frescobaldi development is a waste of time since everyone uses Sibelius anyway. Also, spending time doing a Mac bundle is not worth the time either since nearly everyone uses Windows anyway.

/sarcasm off. Can we please stop judgements about usefulness of (time spent doing X for) software? In particular if you are not able to show any numbers supporting your claims.

@dliessi
Copy link
Collaborator

dliessi commented Dec 21, 2017

You can find here (SHA256: 687171532864485a6e220ed7d0a0488c4443539304c553e45767d11e69535772) a DMG containing a build of Frescobaldi.app from current master (with a couple of changes I will push soon).
If you are interested, please try it and report any problems you encounter (recall the ones already mentioned in #986 (comment)).

@marnen
Copy link
Contributor

marnen commented Dec 21, 2017

@mojca:

Can we please stop judgements about usefulness of (time spent doing X for) software? In particular if you are not able to show any numbers supporting your claims.

I probably shouldn't even respond to this, but...we only have limited time and resources available to us, apparently; that's the nature of most software projects, especially volunteer-driven OSS. As such, it makes sense to think about the best way to allocate those resources. I don't understand the idea that we shouldn't be making judgements; IMHO that's exactly what our critical thinking faculties are for.

If I had numbers, I'd provide them; I don't think such things are available for OSS. But the fact remains that except for @dliessi and you, I haven't heard of anyone using MacPorts in many years, because it's so clumsy and hard to work with; the entire community (that I have contact with) has switched to Homebrew. It makes little sense to have Homebrew and MacPorts on the same computer, so a MacPorts-based approach is not terribly useful for what is probably the larger part of the user community. (Of course, a MacPorts port could be translated to a Homebrew formula, so it isn't entirely useless.)

@marnen
Copy link
Contributor

marnen commented Dec 21, 2017

@dliessi Awesome! I'll check out the new build.

@marnen
Copy link
Contributor

marnen commented Dec 21, 2017

@dliessi I'm trying out the new build. As you know, it still has the same problems as mentioned earlier, so it's not really usable yet. Was it supposed to fix any problems, or just get a build process working for a standalone .app? If it was just supposed to do the latter, then I can report success.

@francisperea
Copy link

francisperea commented Dec 21, 2017

@dliessi I've downloaded you DMG and successfully compiled 2 little pieces, both to PDF and MIDI under OS X 10.13.2.

Is there something in particular I should test for?

Thanks a lot for your work.

@marnen
Copy link
Contributor

marnen commented May 15, 2019

Playing around with the DMG on Mojave as well (10.14.3).

When the app opens, I get the following error:

Traceback (most recent call last):
  File "/private/var/folders/yq/n3t_19_13897mtqk4w1lx7jc0000gq/T/AppTranslocation/EF3958AC-8D5F-4D76-9E97-CDEA5D3B62D9/d/Frescobaldi.app/Contents/Resources/lib/python3.7/frescobaldi_app/sessions/menu.py", line 100, in populate
ValueError: too many values to unpack (expected 2)

Clicking "cancel" either has no effect or brings up the error alert again; ditto the close box. Clicking "email bug report" opens Mail.app and then returns to the error. The error alert is modal; all non-system menu items are disabled, and clicking on the application window just gets an error beep. Even the Quit menu item is disabled, and so I have to force-quit Fresco.

@marnen
Copy link
Contributor

marnen commented May 15, 2019

Hmm, when I copied to a location other than the DMG, I still got the error but was eventually able to cancel my way out of it. But then it reappeared every time I switched focus back to the application. This build is thus essentially unusable on my Mac, but I appreciate @dliessi helping us get a little closer.

@nagymusic
Copy link

nagymusic commented May 19, 2019

How did you close the application? The crash happens whatever method you use to close the application (clicking on the X icon, clicking File>Quit menu or Ctrl-Q)? Or just with specific method?

Just wondering if it might be related to issue #1120

Just a quick update that the crash happens only when clicking on the X icon. Ctrl-Q or File>Quit menu works fine. Reading the above thread, I understand that not everyone is having the same experience. I'm just glad that Frescobaldi can be closed without an error message report... Thank again for your feedback!

By the way, would you happen to know if 3.0.1 may be available for Mac or Linux any time soon? I've been using this newer version on Windows and I like some of the new functionality.

@fedelibre
Copy link
Member

By the way, would you happen to know if 3.0.1 may be available for Mac or Linux any time soon? I've been using this newer version on Windows and I like some of the new functionality.

I think a new minor release (3.0.1) is blocked only because of problems with building installers for Windows and Mac. On the other hand, 3.1 release has still a lot of TODO items.

Anyway, do you know you can easily run Fresco from source in Linux? There's a tutorial in the wiki.

@uliska
Copy link
Collaborator

uliska commented May 19, 2019

I think that there is a "newer" Windows release, but that was only a Windows-related bug fix. There is nothing in any released Windows version that would qualify as "new functionality".

Basically the idea of a 3.0.1 release was discarded in favor of a more comprehensive 3.1 release (I thought such a small step would be somewhat embarrassing after more than two years). Unfortunately it seems 3.1 is still further away than desirable - we would really need a few people contributing actively to Frescobaldi ...

@marnen
Copy link
Contributor

marnen commented May 19, 2019

@fedelibre:

I think a new minor release (3.0.1) is blocked only because of problems with building installers for Windows and Mac.

That sounds implausible to me. I thought that version 3 hadn’t been released for Mac yet because of the outstanding bugs, and it is certainly possible to run it from source on Mac OS, so why would an installer be any more difficult than it was for version 2?

@fedelibre
Copy link
Member

@marnen See above comment from Urs.

Also, there were problems with python-poppler-qt5 on Mac.

@dliessi
Copy link
Collaborator

dliessi commented Dec 28, 2019

Dear all,
the application bundle for Frescobaldi 3.1 is now available.

I would appreciate if you could try it out and check whether the issues you had with the previous builds are still there and whether there are other problems besides the ones already reported here or in the issue tracker.
I am especially interested in the issue reported by @marnen (... too many values to unpack...), since it renders the application pretty unusable.

As for the remaining bugs (see this list), I would appreciate any suggestion.

If you need guidance in running Frescobaldi from source, let me know.
I install Frescobaldi's dependencies with MacPorts.
You can install them also with Homebrew, except for python-poppler-qt5, which you can manually compile and install; @marnen do you think you could provide a formula for python-poppler-qt5 if needed?

@iilei
Copy link

iilei commented Dec 28, 2019

Thank you @dliessi
I just tried to run it and it crashed immediately.
Hope the logs help.

@dliessi
Copy link
Collaborator

dliessi commented Dec 28, 2019

@iilei can you try running it again and checking the error messages in the Console application when it crashes?

@iilei
Copy link

iilei commented Dec 28, 2019

I just tried reinstalling lilypond with homebrew. Looks like Mac OS Catalina doesn`t work with the Cask

❯ brew cask reinstall lilypond
==> Downloading http://lilypond.org/downloads/binaries/darwin-x86/lilypond-2.18.2-1.darwin-x86.tar.bz2
######################################################################## 100.0%
==> Verifying SHA-256 checksum for Cask 'lilypond'.
Error: This cask does not run on macOS versions newer than Mojave.

@marnen
Copy link
Contributor

marnen commented Dec 29, 2019

@dliessi This is awesome news; thanks! I’ll try it out.

@iilei There’s no 64-bit Mac build of LilyPond yet. I’m working on one, but I could use help (see the dev list archives for more info).

@marnen
Copy link
Contributor

marnen commented Dec 29, 2019

@dliessi:

@marnen do you think you could provide a formula for python-poppler-qt5 if needed?

I have no idea. Why do you think I might be able to? (It’s possible, but I’m not sure why you asked me specifically.)

@dliessi
Copy link
Collaborator

dliessi commented Dec 30, 2019

@marnen:

Why do you think I might be able to? (It’s possible, but I’m not sure why you asked me specifically.)

You originally provided the formula for Frescobaldi and python-poppler-qt4, so I just thought you probably have enough knowledge of Homebrew to write a formula for python-poppler-qt5.
I remember that there were some problems earlier in building python-poppler-qt5, but now it can be built manually or via MacPorts, so I expect that we could solve any remaining build problems.
I would do it myself, if needed, but I don't use Homebrew and have little knowledge of its internal details.
I could give it a try, though.

@marnen
Copy link
Contributor

marnen commented Dec 31, 2019

@dliessi I forgot that I provided the python-poppler-qt4 formula. :) I could indeed probably do a similar one for qt5.

I do suggest getting familiar with Homebrew, though. For most use cases that I’m familiar with, it’s far better than the alternatives. (I have no knowledge of Homebrew’s internals either, but they’ve made writing formulae really easy.)

@marnen
Copy link
Contributor

marnen commented Dec 31, 2019

@dliessi I just tried Fresco 3.1 on Mojave. The exact same bugs are still there (truncated tab titles, "too many values to unpack" when doing anything with the Session menu). In addition, I got the following error message when attempting to pinch-zoom the PDF view:

Traceback (most recent call last):
  File "/Applications/Frescobaldi.app/Contents/Resources/lib/python3.7/frescobaldi_app/qpageview/link.py", line 196, in event
  File "/Applications/Frescobaldi.app/Contents/Resources/lib/python3.7/frescobaldi_app/qpageview/view.py", line 1015, in event
  File "/Applications/Frescobaldi.app/Contents/Resources/lib/python3.7/frescobaldi_app/qpageview/view.py", line 1030, in handleGestureEvent
  File "/Applications/Frescobaldi.app/Contents/Resources/lib/python3.7/frescobaldi_app/qpageview/view.py", line 1047, in pinchGesture
NameError: name 'QPinchGesture' is not defined

I really appreciate your effort in packaging this, but the continued presence of these bugs means that this build isn't any more usable than the 3.0 build.

@dliessi
Copy link
Collaborator

dliessi commented Dec 31, 2019

@marnen:

truncated tab titles

In #1087 (comment) there is a minimal example of the problem.
I suspect this is a bug in either Qt or PyQt: I haven't yet reported it to those projects, but I will do it soon.

"too many values to unpack" when doing anything with the Session menu

I still cannot reproduce the issue.
I added it as #1237.
Maybe Wilbert will have some ideas.

In addition, I got the following error message when attempting to pinch-zoom the PDF view: [...]

This is solved in current master (see #1234 and 6365b6d).
However, the pinch gesture zoom is not behaving very well if the pinch is too slow: I'll investigate it.

@marnen
Copy link
Contributor

marnen commented Dec 31, 2019

FWIW, I don't so much care if the pinch gesture is supported (though it would be nice) as that it not bring up an error. :)

@dliessi
Copy link
Collaborator

dliessi commented Jan 6, 2020

Dear all,
the application bundle for Frescobaldi 3.1.1 is now available.

A few bugs have been solved.
Moreover the application bundle is now built with Qt 5.14, which should work on macOS 10.15 Catalina, where some users previously reported immediate crash at startup.

However, there are still several open issues, including the ones reported for the new application bundle.
In particular, convert-ly is still broken on macOS 10.15 Catalina (see #1232) and I still expect problems in running the application on macOS 10.12 Sierra (see #1233).

Please test the new build and report about new and existing issues.
Thanks.

@dliessi
Copy link
Collaborator

dliessi commented Feb 3, 2020

One of the main problems with the current build of the app bundle is #1244 (QtWebEngine is not packaged correctly, so Frescobaldi crashes whenever the documentation browser of the SVG viewer are opened).
In #1244 (comment) I provide minimal test files and some references.
Any help is appreciated, but I will ask for help also from py2app.

@iilei
Copy link

iilei commented Jun 13, 2020

Finally I managed to get the latest version running on my mac. As i am using asdf-vm for managing python versions and also homebrew for some cli tools, I think my setup has led to a few quirks.

Basically I wanted to thank you all for maintaining frescobaldi and having it OSX compatible. 🙂

@dliessi
Copy link
Collaborator

dliessi commented Aug 12, 2020

Since some people are still on 10.11 El Capitan or 10.12 Sierra, I added to the release page for 3.1.2 a build made on 10.11 El Capitan: it should work on that version of macOS and any later version.
The build is for the already released version 3.1.2, so it still contains the workaround for #1244 (instead of a working QtWebEngine) and lacks the latest fixes related to running the Python tools.

@dliessi
Copy link
Collaborator

dliessi commented Aug 12, 2020

[...] so it still contains the workaround for #1244 (instead of a working QtWebEngine) [...]

The way I wrote this sentence may suggest that #1244 is solved in current master.
It is not, and I don't expect a solution in the near future.
Any help is appreciated.

Besides looking for a solution to the packaging bug, adding Frescobaldi (and python-poppler-qt5) to Homebrew as a formula built from source (instead of the current cask installing our prebuilt application bundle) would work around the issue for the many Homebrew users (more than 400 installations in the latest year).
I'll give it a try soon, but any help is appreciated here as well.

@marnen
Copy link
Contributor

marnen commented Aug 12, 2020

Thank you! It looks like this works, without the display bugs that have plagued previous Mac packagings of 3.x, but I'd like to have the documentation browser back before I switch to this version. I've left some comments on #1244; let me know if you need more help.

@jeanas
Copy link
Member

jeanas commented May 31, 2023

It looks like this issue is resolved — we're at Frescobaldi 3.3 with macOS app bundles now, and there are separate issues for problems like the one with QtWebEngine.

@jeanas jeanas closed this as completed May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests