Change mouse pointer to "waiting" while opening documents #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading large documents there may be a significant moment of seeming inactivity. This commit changes the mouse pointer to "wait" during that time. NOTE: This only works when opening a document into the *first* tab. Obviously *some* code inside AbstractDocument.load() must take care of this (i.e. returning only when the document is *fully* loaded).
|
I've tested it and it works as expected. It helps. |
|
Maybe, but I'm of course not satisfied by the fact that it only works for the first tab ... I have the suspicion that this delay is related to the known problem of too-long-running tasks to update the autocompletion and highlighting data. So maybe when that will have been fixed the situation might become different: Files would be opened quickly, with the highlighting kicking in delayed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1109
When loading large documents there may be a significant moment of
seeming inactivity. This commit changes the mouse pointer to "wait"
during that time.
NOTE: This only works when opening a document into the first tab.
Obviously some code inside AbstractDocument.load() must take
care of this (i.e. returning only when the document is fully loaded).
Therefore this pull request should not be merged yet.
@fedelibre please test this both with large original files and in conjunction with file import.