Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the Score Wizard #1343

Merged
merged 12 commits into from Dec 25, 2020
Merged

Improvements to the Score Wizard #1343

merged 12 commits into from Dec 25, 2020

Conversation

bmjcode
Copy link
Contributor

@bmjcode bmjcode commented Nov 28, 2020

Hi there! I've made some improvements to the Score Wizard, including the ability to create a new score based on an existing document. I also did some work on the part types, adding several new instruments and doing some clean-up on existing ones.

Creating scores from existing documents

I added a new command under File -> New -> From Current Document... that pre-populates the Score Wizard's fields based on an existing score. At the moment it handles headers and score properties well, and has partial support for recognizing existing parts -- at least those named following the Score Wizard's own convention. This is a first step towards using the Wizard to edit an existing score in-place, as requested in issue #888.

A few caveats:

  • I have not yet implemented support for identifying parts nested in containers (but hope to soon if I have the time).
  • I have not yet tested how this handles headers containing markup expressions.
  • I have not attempted to preserve non-musical score properties (input language, layout/typography settings, etc.). Would it be useful to copy these from an current score? Or would it be better to leave those to the user's individual preference, as when generating a new score from scratch?

Changes to instrument/part types

I've also added a few new instrument types to the Score Wizard that I think will be especially helpful for writing rock and popular music. Specifically, these are:

  • Plucked strings
    • Acoustic guitar
    • Electric guitar
  • Keyboards
    • Electric piano
    • Synth lead
    • Synth pad
    • Synth bass
    • Synth strings
    • Synth brass

The new guitar types are based on the existing classical guitar and jazz guitar, respectively, but with instrument names that don't tie them to a particular style or genre. They also default to different MIDI sounds, for example steel-string rather than nylon-string for the acoustic guitar. The electric piano is similarly a cosmetic rename of the existing piano type. Listing it separately allows distinguishing that instrument from the acoustic variety in styles (or individual scores) where both are used.

The synth types allow omitting the left- or right-hand parts by setting the corresponding number of voices to zero, to avoid generating extraneous staffs when writing monophonic lines. "Synth lead" and "synth bass" respectively default to a single treble- or bass-clef staff. The other synth types default to two staves, as these are intended for writing polyphonic parts.

Finally, I renamed the plucked string instrument "Bass" to "Acoustic bass" (abbreviated "A.Bs."), to differentiate it from the bass voice or other stringed bass instruments.

@bmjcode bmjcode changed the title New plucked string and keyboard instruments in the Score Wizard Improvements to the Score Wizard Nov 29, 2020
@wbsoft wbsoft merged commit 9c1d483 into frescobaldi:master Dec 25, 2020
@wbsoft
Copy link
Collaborator

wbsoft commented Dec 25, 2020

Looks nice, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants