-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further improvements to the Score Wizard #1375
Conversation
@bmjcode Could you please remove the Then I may test your branch and comment on the features you added. I can't review the code, but maybe others will as soon as you remove that commit and rebase on current master. Sorry for the long delay, but as you can see from the history Frescobaldi development is slowly coming back. We'd like to release 3.3 soon, after fixing the last critical issue. |
@bmjcode I did the cleanup for you and force-pushed to your branch. |
I've now tested it and it looks good. Waiting for others to give feedback on code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me and seem to work as expected.
There is a merge commit in the history, which is undesirable. @bmjcode Can you please rebase your branch on origin/master and push again? (Next time you may use a new branch for submitting changes, instead of master.) Thanks.
Marking my review as "Request changes" for the rebasing, otherwise I approve it.
@dliessi I'll be happy to if you can tell me how to do it. My understanding of Git is frankly pretty limited. |
It's more difficult now that you've rebased on master and your commits are way down the list. I would have squashed them first and then rebased on master. My suggestion is making a backup branch first:
Then change back to the branch of this PR and try fixing the commits:
where that committish is the first commit in this PR. If you're not confident on rebasing you may leave this task to Jean. |
…d bass guitar parts
…y from musical content
Now rebased and merged (based on @dliessi's review; I didn't re-review thoroughly myself). Thank you! |
Cool. Thanks all for your help and patience with this. I have a couple other things I'd like to work on, but they're a bit more complicated. I'll open issues for those so we can talk through the details first. |
Hi there! I've made a few more improvements to the Score Wizard: