MusicXML: recognize stem direction #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoma
force-pushed
the
fix-recognize-stem-direction
branch
from
4f963f6
to
213c4ed
Compare
uliska
reviewed
May 4, 2018
| @@ -30,6 +30,8 @@ def test_dynamics(): | |||
| def test_tuplet(): | |||
| compare_output('tuplet') | |||
|
|
|||
| def test_stem(): | |||
| compate_output('stem') | |||
There was a problem hiding this comment.
This surely should read compare_output?
|
Just after starting to look into this (and verifying that it works correctly) I realized that the functionality has in the meantime been implemented as part of last year's GSoC. So I'm closing this PR, but still thank you very much for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.