Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build error: ordered comparison between pointer and zero #17

Open
dliessi opened this issue Oct 8, 2017 · 1 comment · May be fixed by #18
Open

build error: ordered comparison between pointer and zero #17

dliessi opened this issue Oct 8, 2017 · 1 comment · May be fixed by #18

Comments

@dliessi
Copy link
Contributor

dliessi commented Oct 8, 2017

On macOS High Sierra, building via MacPorts:

:info:build types.sip:30:56: error: ordered comparison between pointer and zero ('PyObject *' (aka '_object *') and 'int')
:info:build         if (obj == NULL || PyList_SET_ITEM (l, i, obj) < 0)
:info:build                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
:info:build 5 warnings and 1 error generated.
:info:build error: command '/usr/bin/clang' failed with exit status 1

See bug report at MacPorts.

(I cannot confirm this personally, as I haven't got High Sierra yet.)
@dliessi
Copy link
Contributor Author

dliessi commented Oct 8, 2017

I forgot to mention: Python 3.5.

dliessi added a commit to dliessi/python-poppler-qt4 that referenced this issue Nov 28, 2017
@dliessi
use PyList_SetItem instead of PyList_SET_ITEM for comparison
799abda 
seems to fix frescobaldi#17
see https://trac.macports.org/ticket/55014#comment:5
@dliessi dliessi linked a pull request Nov 28, 2017 that will close this issue
Open
dliessi added a commit to dliessi/python-poppler-qt5 that referenced this issue Jan 1, 2018
@dliessi
use PyList_SetItem instead of PyList_SET_ITEM for comparison
886d3a0 
see frescobaldi/python-poppler-qt4#17,
frescobaldi/python-poppler-qt4#18,
macports/macports-ports#1064,
and https://trac.macports.org/ticket/55014#comment:7
@dliessi dliessi mentioned this issue Jan 1, 2018
Merged
zehome pushed a commit to zehome/python-poppler-qt5 that referenced this issue Dec 10, 2019
@dliessi
use PyList_SetItem instead of PyList_SET_ITEM for comparison
ac15131 
see frescobaldi/python-poppler-qt4#17,
frescobaldi/python-poppler-qt4#18,
macports/macports-ports#1064,
and https://trac.macports.org/ticket/55014#comment:7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use PyList_SetItem instead of PyList_SET_ITEM for comparison dliessi/python-poppler-qt4
1 participant
@dliessi