Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py-poppler-qt4: patch PyList_SET_ITEM -> PyList_SetItem #1064

Merged
merged 1 commit into from Dec 5, 2017
Merged

py-poppler-qt4: patch PyList_SET_ITEM -> PyList_SetItem #1064

merged 1 commit into from Dec 5, 2017

Conversation

dliessi
Copy link
Contributor

@dliessi dliessi commented Nov 28, 2017

Closes https://trac.macports.org/ticket/55014

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.11.6 15G17023
Xcode 8.2.1 8C1002

Verification

Have you

  • checked your Portfile with port lint?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@mojca
Copy link
Member

mojca commented Dec 5, 2017

As noted in the ticket this also affects py-poppler-qt5.

@mojca mojca mentioned this pull request Dec 5, 2017
Merged
8 tasks
@dliessi @mojca
py-poppler-qt[45]: fix compiler error
1d6aac7 
* Replace PyList_SET_ITEM -> PyList_SetItem
* Add maintainer's github handle

Closes https://trac.macports.org/ticket/55014
@mojca mojca merged commit 69439ab into macports:master Dec 5, 2017
@mojca
Copy link
Member

mojca commented Dec 5, 2017 •
edited

I added the patches for Qt5 as well based on your patches for Qt4.

I had to modify the commit messages because they should fit into 50 characters (which they initially didn't).

@dliessi dliessi deleted the py-poppler-qt4 branch December 5, 2017 20:32
dliessi added a commit to dliessi/python-poppler-qt5 that referenced this pull request Jan 1, 2018
@dliessi
use PyList_SetItem instead of PyList_SET_ITEM for comparison
886d3a0 
see frescobaldi/python-poppler-qt4#17,
frescobaldi/python-poppler-qt4#18,
macports/macports-ports#1064,
and https://trac.macports.org/ticket/55014#comment:7
@dliessi dliessi mentioned this pull request Jan 1, 2018
Merged
zehome pushed a commit to zehome/python-poppler-qt5 that referenced this pull request Dec 10, 2019
@dliessi
use PyList_SetItem instead of PyList_SET_ITEM for comparison
ac15131 
see frescobaldi/python-poppler-qt4#17,
frescobaldi/python-poppler-qt4#18,
macports/macports-ports#1064,
and https://trac.macports.org/ticket/55014#comment:7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintainer: open Affects an openmaintainer port maintainer type: bugfix
Milestone
No milestone
3 participants
@dliessi @mojca @macportsbot