Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS15+ support keyboardLayoutGuide #38

Open
KYHyeon opened this issue Jun 8, 2021 · 6 comments
Open

iOS15+ support keyboardLayoutGuide #38

KYHyeon opened this issue Jun 8, 2021 · 6 comments

Comments

@KYHyeon
Copy link

KYHyeon commented Jun 8, 2021

It appears to officially support keyboardLayoutGuide from iOS15+.
view.keyboardLayoutGuide causes errors 'keyboardLayoutGuide' is only available in iOS 15.0 or newer
image

Reference: https://developer.apple.com/documentation/uikit/uiview/3752221-keyboardlayoutguide

@shgew
Copy link

shgew commented Jun 20, 2021

If you import KeyboardLayoutGuide at the top of the file, the error goes away.

@s4cha
Copy link
Member

s4cha commented Jun 21, 2021

@KYHyeon Yeah I saw they announced keyboardLayoutGuide and I figured names would probably collide.
Looks like we got "Sherlocked" but I'm glad this is now becoming official, it's every maintainer goal !
Does @shgew solution fixes your issue? What version of Xcode are you using to be able to target iOS 15 ?

@MainasuK
Copy link

The workaround not fix the app target for iOS 15 only. The app still find and use the keyboardLayoutGuide from UIKit but not the package.

https://github.com/MainasuK/KeyboardLayoutGuide/tree/fix/iOS15
Rename the guide is works for me. That change will break the other dependencies. So if you think that is fine I could make a PR.

@s4cha
Copy link
Member

s4cha commented Jan 17, 2022

@MainasuK that is weird, just tried locally creating an iOS15+ only app and whenever I add import KeyboardLayoutGuide at the top of the file, it uses the library one and the Native one when removing the import (see screenshots attached)
Screenshot 2022-01-17 at 17 52 50
Screenshot 2022-01-17 at 17 53 02

@MainasuK
Copy link

@s4cha You can try push a view in navigation stack or present a modal then dismiss it. The native one get a bug in iOS 15.0 build in my case.

The bug also described in that blog:
https://useyourloaf.com/blog/keyboard-layout-guide/

@azun-khang
Copy link

Thanks @MainasuK . I have the same issue with you. Luckily, your workaround/fix works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants