Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] - Dropdown button #112

Closed
shravan-balasubramanian opened this issue Aug 17, 2020 · 5 comments · Fixed by #136
Closed

[Feature Request] - Dropdown button #112

shravan-balasubramanian opened this issue Aug 17, 2020 · 5 comments · Fixed by #136

Comments

@shravan-balasubramanian
Copy link
Contributor

shravan-balasubramanian commented Aug 17, 2020

Describe the functionality of the new component:
A dropdown button according to the Design system found in
https://xd.adobe.com/view/a8299f86-4d90-40f9-4d23-7dc26f9266e3-de18/screen/eb6930f3-3b16-49ee-9aaa-3dbc780e7154/

More details:
Screenshot 2020-08-17 at 10 55 50 PM

Properties

This will be part of fw-button itself

Property Attribute Description Type Default
dropdown dropdown dropdown button or not Boolean false
split split Whether to split dropdown or not. Invalid if dropdown is false Boolean false
searchable searchable Whether the dropdown button should be searchable. Invalid if dropdown is false Boolean false
value value Selected options Array undefined
placeholder placeholder Placeholder for search input String ''

Events

Event Description Type
fwOptionClick Emitted on selecting an option customEvent
fwOptionsAdd Emitted on adding options (Add button click) customEvent

Sample HTML

<fw-button dropdown split> Select OTT 
  <span id="1" value="netflix"> Netflix </span>
  <span id="2" value="amazon"> Amazon </span>
</fw-button>
@asif-ahmed-1990
Copy link
Contributor

Can you detail the options part with an example?

@shravan-balasubramanian
Copy link
Contributor Author

shravan-balasubramanian commented Aug 20, 2020

<fw-button size="medium" dropdown options = [
{
  id: '1',
  label: 'Netflix',
  value: 'Amazon'
},
{
  id: 2,
  label: 'Amazon',
  value: 'Amazon'
}
]> OTT
</fw-button>

@asifahmedfw

shravan-balasubramanian added a commit that referenced this issue Aug 28, 2020
Dropdown buttons with various settings - split, searchable

fix #112
@shravan-balasubramanian
Copy link
Contributor Author

@asifahmedfw Can you re-review this and the PR

shravan-balasubramanian added a commit that referenced this issue Aug 28, 2020
shravan-balasubramanian added a commit that referenced this issue Aug 28, 2020
Dropdown buttons with various settings - split, searchable

fix #112
shravan-balasubramanian added a commit that referenced this issue Aug 28, 2020
shravan-balasubramanian added a commit that referenced this issue Aug 30, 2020
shravan-balasubramanian added a commit that referenced this issue Aug 30, 2020
Dropdown buttons with various settings - split, searchable

fix #112
shravan-balasubramanian added a commit that referenced this issue Aug 30, 2020
shravan-balasubramanian added a commit that referenced this issue Aug 30, 2020
Dropdown buttons with various settings - split, searchable

fix #112
shravan-balasubramanian added a commit that referenced this issue Aug 30, 2020
shravan-balasubramanian added a commit that referenced this issue Sep 28, 2020
…System

Dropdown button similar to Select component but build on top of fw-button. It can be searchable,
splittable and supports multi selects

fix #112
shravan-balasubramanian added a commit that referenced this issue Sep 29, 2020
shravan-balasubramanian added a commit that referenced this issue Sep 30, 2020
shravan-balasubramanian added a commit that referenced this issue Sep 30, 2020
shravan-balasubramanian added a commit that referenced this issue Sep 30, 2020
shravan-balasubramanian added a commit that referenced this issue Sep 30, 2020
…System

Dropdown button similar to Select component but build on top of fw-button. It can be searchable,
splittable and supports multi selects

fix #112
shravan-balasubramanian added a commit that referenced this issue Sep 30, 2020
shravan-balasubramanian added a commit that referenced this issue Sep 30, 2020
shravan-balasubramanian added a commit that referenced this issue Sep 30, 2020
shravan-balasubramanian added a commit that referenced this issue Sep 30, 2020
github-actions bot pushed a commit that referenced this issue Sep 30, 2020
# [2.7.0](v2.6.3...v2.7.0) (2020-09-30)

### Features

* **button:** fix type change ([429e7dc](429e7dc)), closes [#112](#112)
* **dropdown button:** add missing css prop ([36c157f](36c157f)), closes [#112](#112)
* **dropdown button:** dropdown button adhering to Freshworks Design System ([43e8bda](43e8bda)), closes [#112](#112)
* **dropdown button:** dropdown button small fix ([003a937](003a937)), closes [#122](#122)
* **dropdown button:** review comments ([43923cd](43923cd)), closes [#112](#112)
* **dropdown button:** review comments - 2 ([b8bfe71](b8bfe71)), closes [#112](#112)
@github-actions
Copy link

🎉 This issue has been resolved in version 2.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 2.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hemchander23 hemchander23 added this to Completed in Roadmap May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment