Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] - Set Values to fw-select with mulitple option. #132

Closed
ghost opened this issue Sep 21, 2020 · 4 comments · Fixed by #139
Closed

[Enhancement] - Set Values to fw-select with mulitple option. #132

ghost opened this issue Sep 21, 2020 · 4 comments · Fixed by #139
Assignees
@narendran-kannan
Labels
enhancement New feature or request hacktoberfest This issue is open for hacktoberfest 2020 released on @next released

Comments

@ghost
Copy link

ghost commented Sep 21, 2020

Description of the enhancement:

Adding an additional method to the <fw-select> </fw-select> component. In order to set values for fw-select component with multiple property, we need a out of box method from FW. Currently, we are manipulating the value of the select element using array methods and re-rendering the fw-select component to DOM.

Describe the solution you'd like

We would like to have a method to set values to fw-select component. Like getSelectedItem() => Promise<any> available for extract values.
@ghost ghost added the enhancement New feature or request label Sep 21, 2020
@asif-ahmed-1990 asif-ahmed-1990 added the hacktoberfest This issue is open for hacktoberfest 2020 label Sep 25, 2020
@narendran-kannan
Copy link
Contributor

I would like to work on this, Kindly assign this to me!
@itzarshath @asifahmedfw

@asif-ahmed-1990
Copy link
Contributor

Assigning this to you @narendran-kannan ! Will be looking forward for your PR!

narendran-kannan added a commit to narendran-kannan/crayons that referenced this issue Oct 1, 2020
@narendran-kannan
feat(components/select/select.tsx): add a method to set selected valu…
1e8d4ac 
…es in fw-select component

Adding an additional method to the fw-select component to set values for the select component with
multiple property

fix freshworks#132
@narendran-kannan narendran-kannan mentioned this issue Oct 1, 2020
Merged
6 tasks
asif-ahmed-1990 pushed a commit that referenced this issue Oct 14, 2020
@narendran-kannan @asif-ahmed-1990
feat(components/select/select.tsx): add a method to set selected valu…
1ea13de 
…es in fw-select component

Adding an additional method to the fw-select component to set values for the select component with
multiple property

fix #132
github-actions bot pushed a commit that referenced this issue Oct 14, 2020
@semantic-release-bot
chore(release): 2.8.0 [skip ci]
a902795 
# [2.8.0](v2.7.1...v2.8.0) (2020-10-14)

### Features

* **components/select/select.tsx:** add a method to set selected values in fw-select component ([1ea13de](1ea13de)), closes [#132](#132)
@github-actions
Copy link

🎉 This issue has been resolved in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@narendran-kannan narendran-kannan

Labels
enhancement New feature or request hacktoberfest This issue is open for hacktoberfest 2020 released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(components/select/select.tsx): add a method to set selected valu… narendran-kannan/crayons
2 participants
@asif-ahmed-1990 @narendran-kannan