Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] - Tag does not get disabled #137

Closed
shravan-balasubramanian opened this issue Sep 30, 2020 · 1 comment · Fixed by #138
Closed

[Bug] - Tag does not get disabled #137

shravan-balasubramanian opened this issue Sep 30, 2020 · 1 comment · Fixed by #138
Assignees
@shravan-balasubramanian
Labels
bug Something isn't working released on @next

Comments

@shravan-balasubramanian
Copy link
Contributor

shravan-balasubramanian commented Sep 30, 2020 •
edited
Loading

Description of the enhancement:
For a disabled multi-select fw-select, the user can still modify the value since the fw-tag used is not disabled

Describe the solution you'd like
Tag also should get disabled
@shravan-balasubramanian shravan-balasubramanian added the enhancement New feature or request label Sep 30, 2020
@shravan-balasubramanian shravan-balasubramanian changed the title [Enhancement] - Introduced disabled property for tag component [Enhancement] - Introduce disabled property for tag component Sep 30, 2020
@shravan-balasubramanian shravan-balasubramanian changed the title [Enhancement] - Introduce disabled property for tag component [Bug] - Tag does not get disabled Sep 30, 2020
@shravan-balasubramanian shravan-balasubramanian added bug Something isn't working and removed enhancement New feature or request labels Sep 30, 2020
shravan-balasubramanian added a commit that referenced this issue Sep 30, 2020
@shravan-balasubramanian
fix(select): fixed tag not getting disabled
7cdf2b4 
Disable all tags if multi select is disabled

fix #137
Merged
6 tasks
shravan-balasubramanian added a commit that referenced this issue Sep 30, 2020
@shravan-balasubramanian
fix(select): fixed tag not getting disabled
3723830 
Disable all tags if multi select is disabled

fix #137
github-actions bot pushed a commit that referenced this issue Sep 30, 2020
@semantic-release-bot
chore(release): 2.6.2 [skip ci]
082f80d 
## [2.6.2](v2.6.1...v2.6.2) (2020-09-30)

### Bug Fixes

* **select:** fixed tag not getting disabled ([3723830](3723830)), closes [#137](#137)
@github-actions
Copy link

🎉 This issue has been resolved in version 2.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shravan-balasubramanian shravan-balasubramanian

Labels
bug Something isn't working released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(select): fixed tag not getting disabled freshworks/crayons
1 participant
@shravan-balasubramanian