Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] - fw-icon doesn't work in a Vue application #143

Closed
shravan-balasubramanian opened this issue Oct 12, 2020 · 2 comments · Fixed by #144
Closed

[Bug] - fw-icon doesn't work in a Vue application #143

shravan-balasubramanian opened this issue Oct 12, 2020 · 2 comments · Fixed by #144
Labels
bug Something isn't working hacktoberfest This issue is open for hacktoberfest 2020 released on @next

Comments

@shravan-balasubramanian
Copy link
Contributor

shravan-balasubramanian commented Oct 12, 2020 •
edited

Component
fw-icon

Describe the bug
Icon component does not work in Vue app( or anywhere else I guess! ), since it tries to fetch the icon.svg from the current web app and from the component library

To Reproduce

  • Include component in the vue app
  • Icon component is not displayed
  • Go to networks tab and search for the icon name ( e.g add-contact if the html you included is <fw-icon name="add-contact" size="18" color="green"></fw-icon>)
  • This line tries to fetch from that current server and does not return svg, probably because of getAssetPath not returning correct path ionic-team/stencil#2269

Expected behavior
Icon should be displayed

Screenshots
Screenshot 2020-10-12 at 10 47 47 PM
Screenshot 2020-10-12 at 10 46 20 PM
@shravan-balasubramanian shravan-balasubramanian added the bug Something isn't working label Oct 12, 2020
@shravan-balasubramanian shravan-balasubramanian changed the title [Bug] - fw-icon doesn't work since in a Vue app [Bug] - fw-icon doesn't work in a Vue application Oct 12, 2020
@shravan-balasubramanian shravan-balasubramanian added the hacktoberfest This issue is open for hacktoberfest 2020 label Oct 12, 2020
@existentialcoder
Copy link
Contributor

I will pick this up @asifahmedfw

existentialcoder added a commit to existentialcoder/crayons that referenced this issue Oct 24, 2020
@existentialcoder
fix(icon): fixes icon url path error
e4cd2e1 
Icons url path is fetched wrongly and icons are not displayed

fix freshworks#143
@existentialcoder existentialcoder mentioned this issue Oct 24, 2020
Merged
6 tasks
existentialcoder added a commit to existentialcoder/crayons that referenced this issue Oct 24, 2020
@existentialcoder
fix(icon): minor gulp file fix
4ef6163 
Minor gulp file fix

fix freshworks#143
existentialcoder added a commit to existentialcoder/crayons that referenced this issue Oct 24, 2020
@existentialcoder
fix(icon): add gulp task to test
6fc9106 
Add gulp task to test

fix freshworks#143
asif-ahmed-1990 pushed a commit that referenced this issue Oct 28, 2020
@existentialcoder @asif-ahmed-1990
fix(icon): fixes icon url path error
c20bdd8 
Icons url path is fetched wrongly and icons are not displayed

fix #143
asif-ahmed-1990 pushed a commit that referenced this issue Oct 28, 2020
@existentialcoder @asif-ahmed-1990
fix(icon): minor gulp file fix
db2d920 
Minor gulp file fix

fix #143
asif-ahmed-1990 pushed a commit that referenced this issue Oct 28, 2020
@existentialcoder @asif-ahmed-1990
fix(icon): add gulp task to test
d84eaa3 
Add gulp task to test

fix #143
github-actions bot pushed a commit that referenced this issue Oct 28, 2020
@semantic-release-bot
chore(release): 2.8.1 [skip ci]
f1d7809 
## [2.8.1](v2.8.0...v2.8.1) (2020-10-28)

### Bug Fixes

* **icon:** add gulp task to test ([d84eaa3](d84eaa3)), closes [#143](#143)
* **icon:** fixes icon url path error ([c20bdd8](c20bdd8)), closes [#143](#143)
* **icon:** minor gulp file fix ([db2d920](db2d920)), closes [#143](#143)
@github-actions
Copy link

🎉 This issue has been resolved in version 2.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working hacktoberfest This issue is open for hacktoberfest 2020 released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(icon): fixes icon url path error existentialcoder/crayons
2 participants
@existentialcoder @shravan-balasubramanian