-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fw-datepicker #46
Comments
@sathishkumar-thangavel A few doubts questions:
|
okay I'll rename and change the boolean type to string with ('range'/'single date')
I thought of reuse startDate as value for singleDate(not good idea though). I'll add value which is for mode 'single date'
startTime and endTime attributes only will be extra to it for time selection.
I do have that doubt, if it's okay to add in next update, we can hold.
will rename the event name |
@asifahmedfw as I'm discussed with designer, timepicker can be a seprate component, people mostly not using and it'll be complex. So updated the properties above( removed timepicker properties) |
@sathishkumar-thangavel There is already a timepicker. Datepicker needs to have a timepicker. You can take that in second phase but make sure no interface changes when you introduce timepicker. |
Reference:
https://freshworks.invisionapp.com/dsm/freshworks/freshworks/folder/components/5c68fa78fb26bb0018554084
Date range picker - should allow date and date range selection and date range input field.
Will use fw-input.
Properties
Events
The text was updated successfully, but these errors were encountered: