Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fw-datepicker #46

Closed
ghost opened this issue Mar 30, 2020 · 4 comments
Closed

fw-datepicker #46

ghost opened this issue Mar 30, 2020 · 4 comments

Comments

@ghost
Copy link

ghost commented Mar 30, 2020

Reference:
https://freshworks.invisionapp.com/dsm/freshworks/freshworks/folder/components/5c68fa78fb26bb0018554084

Date range picker - should allow date and date range selection and date range input field.
Will use fw-input.

Properties

Property Attribute Description Type Default
startDate start-date from date of range date none
endDate end-date to date of range date none
minDate min-date earliest date user can select date none
maxDate max-date latest date user can select date none
mode mode to show (single date/range) String single date
dateFormat date-format displaying date format string DD-MM-YYYY
dateValue date-value the selected date value in single date mode date none
placeholder placeholder Placeholder of input field string 'Select Date' or 'Select Date Range'

Events

Event Description Type
fwChange Emitted start/end date selection change customEvent
@ghost ghost added the component-spec label Mar 30, 2020
@ghost ghost assigned asif-ahmed-1990 Mar 30, 2020
@ghost ghost changed the title [draft] fw-datepicker fw-datepicker Mar 30, 2020
@ghost ghost assigned hemchander23 Mar 31, 2020
@asif-ahmed-1990
Copy link
Contributor

@sathishkumar-thangavel A few doubts questions:

  • Can we have 'mode' as and attribute that can have 'range' and other attributes instead of specifying singledatepicker?
  • missing things like value. To fetch the date.
  • If you are doing time selection, do we need to add more attributes?
  • Should component be compatible with i18n?
  • fwChange

@ghost
Copy link
Author

ghost commented Mar 31, 2020

  • Can we have 'mode' as and attribute that can have 'range' and other attributes instead of specifying singledatepicker?

okay I'll rename and change the boolean type to string with ('range'/'single date')

  • missing things like value. To fetch the date.

I thought of reuse startDate as value for singleDate(not good idea though). I'll add value which is for mode 'single date'

  • If you are doing time selection, do we need to add more attributes?

startTime and endTime attributes only will be extra to it for time selection.

  • Should component be compatible with i18n?

I do have that doubt, if it's okay to add in next update, we can hold.

  • fwChange

will rename the event name

@ghost
Copy link
Author

ghost commented Apr 22, 2020

@asifahmedfw as I'm discussed with designer, timepicker can be a seprate component, people mostly not using and it'll be complex. So updated the properties above( removed timepicker properties)

@asif-ahmed-1990
Copy link
Contributor

@sathishkumar-thangavel There is already a timepicker. Datepicker needs to have a timepicker. You can take that in second phase but make sure no interface changes when you introduce timepicker.

@ghost ghost closed this as completed Jun 23, 2020
@hemchander23 hemchander23 added this to Completed in Roadmap May 25, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roadmap
Completed
Development

No branches or pull requests

2 participants