review by coderobe

datagrip/.SRCINFO

@@ -1,10 +1,10 @@
 pkgbase = datagrip
 	pkgdesc = Smart SQL Editor and Advanced Database Client Packed Together for Optimum Productivity
 	pkgver = 2020.1.3
-	pkgrel = 1
+	pkgrel = 2
 	url = https://www.jetbrains.com/datagrip/
 	arch = any
-	license = commercial
+	license = custom:jetbrains
 	depends = glib2
 	conflicts = 0xdbe
 	conflicts = 0xdbe-eap

datagrip/PKGBUILD

@@ -3,11 +3,11 @@
 pkgbase=datagrip
 pkgname=(datagrip datagrip-jre)
 pkgver=2020.1.3
-pkgrel=1
+pkgrel=2
 pkgdesc='Smart SQL Editor and Advanced Database Client Packed Together for Optimum Productivity'
 arch=('any')
 url='https://www.jetbrains.com/datagrip/'
-license=('commercial')
+license=('custom:jetbrains')
 depends=('glib2')
 conflicts=('0xdbe' '0xdbe-eap')
 options=('!strip')

or-tools-java/PKGBUILD

@@ -41,7 +41,7 @@ prepare() {
     srcfolder=${src##*/}
     srcfolder=${srcfolder%.git}
     echo "s#${src#git+}#${srcdir}/${srcfolder}#"
-    sed -i "s#${src#git+}#${srcdir}/${srcfolder}#" ${srcdir}/${pkgname%-java}-${pkgver}/makefiles/Makefile.third_party.unix.mk
+    sed -i "s#${src#git+}#${srcdir}/${srcfolder}#" "${srcdir}"/${pkgname%-java}-${pkgver}/makefiles/Makefile.third_party.unix.mk
   done
 }
 

pass-sshaskpass-git/.SRCINFO

@@ -1,10 +1,10 @@
 pkgbase = pass-sshaskpass-git
 	pkgdesc = Get ssh passphrase from pass
 	pkgver = 18.698346b
-	pkgrel = 1
+	pkgrel = 2
 	url = https://github.com/jlesquembre/pass-sshaskpass
 	arch = any
-	license = GPLv2
+	license = GPL2
 	makedepends = git
 	depends = pass
 	depends = zenity

pass-sshaskpass-git/PKGBUILD

@@ -3,10 +3,10 @@
 
 pkgname=pass-sshaskpass-git
 pkgver=18.698346b
-pkgrel=1
+pkgrel=2
 pkgdesc='Get ssh passphrase from pass'
 url='https://github.com/jlesquembre/pass-sshaskpass'
-license=('GPLv2')
+license=('GPL2')
 arch=('any')
 depends=('pass' 'zenity')
 makedepends=('git')

tomighty/PKGBUILD

@@ -29,7 +29,7 @@ prepare() {
 build() {
   cd ${pkgname}
   mvn clean package
-  convert ${srcdir}/tomato.ico ${srcdir}/tomato.png
+  convert "${srcdir}"/tomato.ico "${srcdir}"/tomato.png
 }
 
 package() {

tpacpi-bat-git/.SRCINFO

@@ -4,7 +4,7 @@ pkgbase = tpacpi-bat-git
 	pkgrel = 1
 	url = https://github.com/teleshoes/tpacpi-bat
 	arch = any
-	license = GPLv3
+	license = GPL3
 	makedepends = git
 	depends = perl
 	depends = acpi_call

tpacpi-bat-git/PKGBUILD

@@ -7,7 +7,7 @@ pkgrel=1
 pkgdesc='A Perl script with ACPI calls for recent ThinkPads which are not supported by tp_smapi'
 arch=('any')
 url='https://github.com/teleshoes/tpacpi-bat'
-license=('GPLv3')
+license=('GPL3')
 depends=('perl' 'acpi_call')
 makedepends=('git')
 provides=('tpacpi-bat')

unifi-beta/.SRCINFO

@@ -2,7 +2,7 @@ pkgbase = unifi-beta
 	pkgdesc = Controller for Ubiquiti UniFi accesspoints
 	pkgver = 5.13.26
 	pkgrel = 1
-	url = http://www.ubnt.com/
+	url = https://www.ubnt.com/
 	arch = x86_64
 	arch = armv7h
 	arch = aarch64

unifi-beta/PKGBUILD

@@ -7,7 +7,7 @@ _pkgver=601d3b699e
 pkgrel=1
 pkgdesc='Controller for Ubiquiti UniFi accesspoints'
 arch=('x86_64' 'armv7h' 'aarch64')
-url='http://www.ubnt.com/'
+url='https://www.ubnt.com/'
 license=('custom')
 depends=('mongodb' 'java-runtime' 'fontconfig')
 provides=('unifi')

youtrack/.SRCINFO

@@ -1,11 +1,11 @@
 pkgbase = youtrack
 	pkgdesc = Issue tracker designed for development teams
 	pkgver = 2020.1.5557
-	pkgrel = 1
+	pkgrel = 2
 	url = https://www.jetbrains.com/youtrack/
 	arch = i686
 	arch = x86_64
-	license = commercial:jetbrains
+	license = custom:jetbrains
 	depends = java-runtime-headless
 	noextract = youtrack.jar
 	options = !strip

youtrack/PKGBUILD

@@ -2,11 +2,11 @@
 
 pkgname=youtrack
 pkgver=2020.1.5557
-pkgrel=1
+pkgrel=2
 pkgdesc='Issue tracker designed for development teams'
 arch=('i686' 'x86_64')
 url='https://www.jetbrains.com/youtrack/'
-license=('commercial:jetbrains')
+license=('custom:jetbrains')
 depends=('java-runtime-headless')
 backup=('etc/youtrack/youtrack.conf')
 options=('!strip')