Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed SKNet model definitions #106

Merged
merged 1 commit into from
Nov 17, 2020
Merged

fix: Fixed SKNet model definitions #106

merged 1 commit into from
Nov 17, 2020

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Nov 17, 2020

SKNet models larger than SKNet-50 were wrongly defined.

@frgfm frgfm added type: bug Something isn't working module: models labels Nov 17, 2020
@frgfm frgfm added this to the 0.1.4 milestone Nov 17, 2020
@frgfm frgfm self-assigned this Nov 17, 2020
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #106 (38b7ae5) into master (60b5d22) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files          48       48           
  Lines        2745     2745           
=======================================
  Hits         2499     2499           
  Misses        246      246           
Impacted Files Coverage Δ
holocron/models/sknet.py 100.00% <100.00%> (ø)

@frgfm frgfm merged commit 70e169b into master Nov 17, 2020
@frgfm frgfm deleted the sknet-pretrained branch November 17, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: models type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant