Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removed implementations of nn that are now integrated in PyTorch #157

Merged
merged 7 commits into from
Nov 6, 2021

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Nov 6, 2021

This PR introduces the following modifications:

  • deprecate SiLU & Mish now that they are integrated in PyTorch (>=1.9.0)
  • updated documentation, unittests and readme accordingly
  • adapted implementations using those

@frgfm frgfm added topic: documentation Improvements or additions to documentation type: enhancement New feature or request module: nn module: models ext: tests Related to test labels Nov 6, 2021
@frgfm frgfm added this to the 0.2.0 milestone Nov 6, 2021
@frgfm frgfm self-assigned this Nov 6, 2021
@codecov
Copy link

codecov bot commented Nov 6, 2021

Codecov Report

Merging #157 (a8b4fdb) into master (735e15a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage   92.25%   92.26%   +0.01%     
==========================================
  Files          52       52              
  Lines        3046     3039       -7     
==========================================
- Hits         2810     2804       -6     
+ Misses        236      235       -1     
Impacted Files Coverage Δ
holocron/models/darknetv4.py 100.00% <100.00%> (ø)
holocron/models/detection/yolov4.py 97.56% <100.00%> (ø)
holocron/models/rexnet.py 100.00% <100.00%> (ø)
holocron/models/segmentation/unet.py 98.68% <100.00%> (ø)
holocron/nn/functional.py 92.44% <100.00%> (-0.13%) ⬇️
holocron/nn/modules/activation.py 93.33% <100.00%> (-2.13%) ⬇️
holocron/utils/data/collate.py 100.00% <100.00%> (+6.25%) ⬆️

@frgfm frgfm merged commit 229d90b into master Nov 6, 2021
@frgfm frgfm deleted the nn-refactor branch November 6, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to test module: models module: nn topic: documentation Improvements or additions to documentation type: breaking change type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant