Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds support for Adan optimizer #244

Merged
merged 6 commits into from Sep 2, 2022
Merged

feat: Adds support for Adan optimizer #244

merged 6 commits into from Sep 2, 2022

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Sep 2, 2022

This PR introduces the following modifications:

  • adds holocron.optim.Adan optimizer
  • adds unittest and documentation entry
  • adds full update rule in the docstring
  • updates the README

@frgfm frgfm added topic: documentation Improvements or additions to documentation module: optim ext: tests Related to test ext: docs type: new feature labels Sep 2, 2022
@frgfm frgfm added this to the 0.3.0 milestone Sep 2, 2022
@frgfm frgfm self-assigned this Sep 2, 2022
@frgfm frgfm mentioned this pull request Sep 2, 2022
11 tasks
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #244 (330e742) into main (154f26c) will decrease coverage by 0.12%.
The diff coverage is 88.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   93.61%   93.49%   -0.13%     
==========================================
  Files          58       59       +1     
  Lines        3274     3349      +75     
==========================================
+ Hits         3065     3131      +66     
- Misses        209      218       +9     
Impacted Files Coverage Δ
holocron/optim/functional.py 84.84% <84.61%> (-0.09%) ⬇️
holocron/optim/adan.py 89.58% <89.58%> (ø)
holocron/optim/__init__.py 100.00% <100.00%> (ø)

@frgfm frgfm merged commit 2174342 into main Sep 2, 2022
@frgfm frgfm deleted the adan branch September 2, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: docs ext: tests Related to test module: optim topic: documentation Improvements or additions to documentation type: new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant