Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added DropBlock implementation #53

Merged
merged 3 commits into from
Jul 8, 2020
Merged

feat: Added DropBlock implementation #53

merged 3 commits into from
Jul 8, 2020

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Jul 8, 2020

This PR introduces dropblock by:

  • adding functional and module APIs
  • adding them to the documentation
  • adding corresponding unittests

@frgfm frgfm added topic: documentation Improvements or additions to documentation type: enhancement New feature or request module: nn ext: tests Related to test labels Jul 8, 2020
@frgfm frgfm added this to the 0.1.2 milestone Jul 8, 2020
@frgfm frgfm self-assigned this Jul 8, 2020
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #53 into master will increase coverage by 0.22%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   85.23%   85.45%   +0.22%     
==========================================
  Files          30       31       +1     
  Lines        1571     1602      +31     
==========================================
+ Hits         1339     1369      +30     
- Misses        232      233       +1     
Impacted Files Coverage Δ
holocron/nn/modules/dropblock.py 94.11% <94.11%> (ø)
holocron/nn/functional.py 95.41% <100.00%> (+0.62%) ⬆️
holocron/nn/modules/__init__.py 100.00% <100.00%> (ø)

@frgfm frgfm merged commit a786789 into master Jul 8, 2020
@frgfm frgfm deleted the dropblock branch July 8, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to test module: nn topic: documentation Improvements or additions to documentation type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant