Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Bumps ruff & black, removes isort & pydocstyle #216

Merged
merged 15 commits into from
Jul 13, 2023
Merged

style: Bumps ruff & black, removes isort & pydocstyle #216

merged 15 commits into from
Jul 13, 2023

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Jul 13, 2023

This PR introduces the following modifications:

  • bumps ruff to 0.0.278
  • bumps black to 23.3.0
  • bumps mypy to 1.4.1
  • removes isort and pydocstyle (handled by ruff)
  • adds additional rules for ruff
  • fixes everything
  • updates CI, Makefile & precommit config

@frgfm frgfm added the type: improvement New feature or request label Jul 13, 2023
@frgfm frgfm added this to the 0.3.3 milestone Jul 13, 2023
@frgfm frgfm self-assigned this Jul 13, 2023
@darth-quack
Copy link

darth-quack bot commented Jul 13, 2023

Nice of you to open a PR 🙏
When you're ready and want to get it reviewed, post a comment in this Pull Request with this message: /quack review

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #216 (69d2834) into main (b533442) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   96.80%   96.80%           
=======================================
  Files           8        8           
  Lines         438      438           
=======================================
  Hits          424      424           
  Misses         14       14           
Impacted Files Coverage Δ
torchcam/methods/_utils.py 100.00% <ø> (ø)
torchcam/methods/core.py 96.03% <ø> (ø)
torchcam/utils.py 84.61% <ø> (ø)
torchcam/__init__.py 60.00% <100.00%> (ø)
torchcam/methods/activation.py 97.56% <100.00%> (ø)
torchcam/methods/gradient.py 98.94% <100.00%> (ø)
torchcam/metrics.py 97.61% <100.00%> (ø)

@frgfm frgfm merged commit dee2e74 into main Jul 13, 2023
21 of 23 checks passed
@frgfm frgfm deleted the quality branch July 13, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant