Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoding number parameters in Url #197

Closed
mikolus opened this issue Jul 25, 2017 · 2 comments
Closed

Encoding number parameters in Url #197

mikolus opened this issue Jul 25, 2017 · 2 comments

Comments

@mikolus
Copy link

mikolus commented Jul 25, 2017

Fix for #172 adds call to the encodeURIComponent for url parameters even when the parameter is number, but that method only takes string. I guess it should check for the type of the parameter.
@frhagn
Copy link
Owner

frhagn commented Jul 25, 2017

Hi @mikolus, sorry about that!
I've published a new version (1.12.1) that should resolve this issue, could you please confirm? Thanks

@mikolus
Copy link
Author

mikolus commented Jul 25, 2017

Perfect, it works great, thanks a lot!

@mikolus mikolus closed this as completed Jul 25, 2017
@enriko-riba enriko-riba mentioned this issue Jul 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frhagn @mikolus