Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Manually assigning a relic during relic creation doesn't correctly set the owner #184

Closed
fribbels opened this issue Mar 6, 2024 · 1 comment
Closed

[Bug] Manually assigning a relic during relic creation doesn't correctly set the owner #184

fribbels opened this issue Mar 6, 2024 · 1 comment
Labels
good first issue Good for newcomers ready for release To be merged into main in the next update

Comments

@fribbels
Copy link
Owner

fribbels commented Mar 6, 2024

Repro steps:

  • Add/import some characters
  • Manually "Add new relic" and select an owner for the relic on the modal
  • Relic gets created showing the owner avatar, but on the Characters tab it doesn't update their build

Desired behavior: Build updates with the newly created relic & unequips the old relic
@fribbels fribbels changed the title Bug: Manually assigning a relic during relic creation doesn't correctly set the owner [Bug] Manually assigning a relic during relic creation doesn't correctly set the owner Mar 8, 2024
@fribbels fribbels added the good first issue Good for newcomers label Mar 12, 2024
@Kenste Kenste mentioned this issue Apr 4, 2024
Merged
3 tasks
Kenste added a commit to Kenste/hsr-optimizer that referenced this issue Apr 5, 2024
@Kenste
fix(DB): consistency in DB setRelic and equipRelic
598c499 
fix fribbels#184
fix relic equip logic when relic part is changed
fix relic assigning consistency
fribbels pushed a commit that referenced this issue Apr 5, 2024
@Kenste
fix: set relic owner correctly on creation (#259)
0e7447f 
* fix: set relic owner correctly on creation

* fix(DB): consistency in DB setRelic and equipRelic

fix #184
fix relic equip logic when relic part is changed
fix relic assigning consistency
@fribbels fribbels added the ready for release To be merged into main in the next update label Apr 9, 2024
@fribbels
Copy link
Owner Author

Released in #298

@fribbels fribbels reopened this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers ready for release To be merged into main in the next update
Projects
Fribbels HSR Optimizer Kanban Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fribbels