Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added All and None buttons to character select screen. #445

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

WolfBungalow
Copy link

@WolfBungalow WolfBungalow commented Jun 19, 2024

Description

I added "All" and "None" buttons to the character selection screen. Please review my work, as I am unsure if I did it correctly. These buttons work with the Element and Path filters, only affecting the visible characters.

Related Issue

Closes #444

Checklist

  • I have added commit messages that are descriptive and meaningful.
  • I have tested the changes locally.
  • I have reviewed the code changes.

Screenshots

image

@fribbels
Copy link
Owner

Changing the buttons for clarity:

image

@fribbels
Copy link
Owner

Thanks for the help on this, sending to beta

@fribbels fribbels merged commit e893520 into fribbels:beta Jun 20, 2024
1 check passed
@WolfBungalow
Copy link
Author

I had kept the min width to take from the textbox width and still look nice at window min width. Here is what it looks like right now if you reduce the window width to minimum. There is overflow off the window.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants