Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manpages in doc/ are empty in 1.0.12 tarball #197

Closed
aelmahmoudy opened this issue Apr 13, 2023 · 6 comments
Closed

Manpages in doc/ are empty in 1.0.12 tarball #197

aelmahmoudy opened this issue Apr 13, 2023 · 6 comments

Comments

@aelmahmoudy
Copy link

aelmahmoudy commented Apr 13, 2023

Also I notice that c2man is required to build the manpages, yet Debian doesn't have that, and it wouldn't be practicle to add c2man to Debian, just to build fribidi manpages. There's a src2man in Debian, could that be used to generate manpages for fribidi ?

@doronbehar
Copy link

I just noticed that today too here on NixOS. I tried to package c2man for NixOS but it proved to be impossible - it's so old that it doesn't use autoconf and automake at all, and it's ./Configure build script failed for me because it can't run on modern machines anymore. This is certainly an issue. src2man looks promising.

@khaledhosny
Copy link
Collaborator

c2man is indeed needed when the tarball is generated, we have a copy of of the source in https://github.com/fribidi/c2man and I think @dov needs to build and install it before generating the release tarball.

It is been a while since I looked at c2man alternatives, but it seemed to be a lot of work back then.

@khaledhosny
Copy link
Collaborator

I manged to build c2man but now it is choking on some C syntax in a system header. At this point, I think we should extract the man pages from the last tarball that had them, commit them to the repository and dropping c2man completely. Maintaining the man pages manually (they seldom change) is probably much less effort than the alternatives.

CC @behdad

@dov
Copy link
Contributor

dov commented May 16, 2023

Thanks @khaledhosny and @aelmahmoudy . I rebuilt c2man and then did a make distcheck and they see to be ok now. Since I don't like changing released file, I'll bump the version to 1.0.13 and will push a new release.

dov added a commit that referenced this issue May 16, 2023
- The version change was done without source changes to allow updating
  the tar release file, which was missing man pages. Issue #197.
@dov
Copy link
Contributor

dov commented May 16, 2023

Fixed in version v1.0.13

@dov dov closed this as completed May 16, 2023
@aelmahmoudy
Copy link
Author

aelmahmoudy commented May 17, 2023 via email

triallax added a commit to triallax/void-packages that referenced this issue Jun 5, 2023
triallax added a commit to triallax/void-packages that referenced this issue Jun 5, 2023
abenson pushed a commit to void-linux/void-packages that referenced this issue Jun 11, 2023
Fixes empty manpages, see fribidi/fribidi#197.

Closes: #44283 [via git-merge-pr]
sirkhancision pushed a commit to sirkhancision/void-packages that referenced this issue Jun 12, 2023
Fixes empty manpages, see fribidi/fribidi#197.

Closes: void-linux#44283 [via git-merge-pr]
sirkhancision pushed a commit to sirkhancision/void-packages that referenced this issue Jun 27, 2023
Fixes empty manpages, see fribidi/fribidi#197.

Closes: void-linux#44283 [via git-merge-pr]
rederick29 pushed a commit to rederick29/void-packages that referenced this issue Jun 29, 2023
Fixes empty manpages, see fribidi/fribidi#197.

Closes: void-linux#44283 [via git-merge-pr]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants