Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What FRIBIDI_NAMESPACE is for #60

Closed
khaledhosny opened this issue Feb 14, 2018 · 2 comments
Closed

What FRIBIDI_NAMESPACE is for #60

khaledhosny opened this issue Feb 14, 2018 · 2 comments

Comments

@khaledhosny
Copy link
Collaborator

I have always wondered about the point of doing:

#define fribidi_get_bracket FRIBIDI_NAMESPACE(get_bracket)
FRIBIDI_ENTRY FriBidiBracketType fribidi_get_bracket (
…
)
@behdad
Copy link
Collaborator

behdad commented Feb 14, 2018

I did this on request from Owen Taylor back circa 2004. Those days we didn't have hidden attribute or export symbol lists. The idea was that the fribidi embedded in Pango could use symbol names different from the standalone fribidi library, such that apps like AbiWord that pull both in wouldn't clash their symbols.

Go ahead, remove it.

@behdad behdad closed this as completed Feb 14, 2018
@behdad behdad reopened this Feb 14, 2018
@khaledhosny
Copy link
Collaborator Author

OK, will do after #59 is merged to avoid conflicts.

khaledhosny added a commit to khaledhosny/fribidi that referenced this issue Feb 19, 2018
behdad pushed a commit that referenced this issue Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants