Properly export fribidi_unicode_version - #110
Merged
Merged
Conversation
|
Yes I can confirm that this patch fixes the problem in meson build, hopefully there will be a new release of fribidi soon so archlinux package can have this fix, in the meantime i will suggest the patch to the package maintainer. |
Contributor
|
Thanks! |
Pango fails to build with above error after this change. |
khaledhosny
added a commit
that referenced
this pull request
May 25, 2019
Contributor
|
Should be fixed now. |
Contributor
Author
|
Ah yep, sorry about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #109
I can't actually test on this machine to verify it solves the issue, so if someone else quickly could that would be fantastic (@moham96?).
To ensure issues like this don't crop up in the future it would probably be best to pass
-fvisibility=hiddento autotools builds as well, but I think that's best addressed by someone more familiar with it than I.