Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly export fribidi_unicode_version #110

Merged
merged 1 commit into from May 24, 2019

Conversation

CoffeeFlux
Copy link
Contributor

Resolves #109

I can't actually test on this machine to verify it solves the issue, so if someone else quickly could that would be fantastic (@moham96?).

To ensure issues like this don't crop up in the future it would probably be best to pass -fvisibility=hidden to autotools builds as well, but I think that's best addressed by someone more familiar with it than I.

@moham96
Copy link

moham96 commented May 24, 2019

Yes I can confirm that this patch fixes the problem in meson build, hopefully there will be a new release of fribidi soon so archlinux package can have this fix, in the meantime i will suggest the patch to the package maintainer.
Thanks for the quick fix.

@khaledhosny khaledhosny merged commit a4eac7a into fribidi:master May 24, 2019
@khaledhosny
Copy link
Collaborator

Thanks!

@muktupavels
Copy link

/mnt/wd20ezrx-00dc0b0/JHBuild/latest/install/include/fribidi/fribidi.h:55:27: error: redundant redeclaration of ‘fribidi_unicode_version’ [-Werror=redundant-decls]
 FRIBIDI_ENTRY const char *fribidi_unicode_version;
                           ^~~~~~~~~~~~~~~~~~~~~~~
In file included from /mnt/wd20ezrx-00dc0b0/JHBuild/latest/install/include/fribidi/fribidi.h:31,
                 from ../pango/pango-bidi-type.c:44:
/mnt/wd20ezrx-00dc0b0/JHBuild/latest/install/include/fribidi/fribidi-unicode.h:48:20: note: previous declaration of ‘fribidi_unicode_version’ was here
 extern const char *fribidi_unicode_version;
                    ^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
ninja: build stopped: subcommand failed.

Pango fails to build with above error after this change.

khaledhosny added a commit that referenced this pull request May 25, 2019
@khaledhosny
Copy link
Collaborator

Should be fixed now.

@CoffeeFlux
Copy link
Contributor Author

Ah yep, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

symbols are not included when building with optimization
4 participants