Add -DFRIBIDI_LIB_STATIC to libfribidi_dep

[xclaesse]

It is needed when fribidi is used as subproject and is static linked on
Windows. The pkg-config file already contains it for the same reason.

[xclaesse]

CC @nirbheek

[nirbheek]

LGTM.

[xclaesse]

Thanks but I don't have merge permission, do you?

[dov]

Any idea of why one of the build tests failed? Is the patching causing the build to be static by default? Is this the common convention?

[tp-m]

Any idea of why one of the build tests failed? Is the patching causing the build to be static by default? Is this the common convention?

It looks like this is an issue that's unrelated to this PR?

It looks like it's the autotools distcheck that fails (run_tests.sh in particular).

Unfortunately I don't see any useful output in the build log with more information what failed exactly, nor are there any artefacts like test logs uploaded by the ci.

I don't see how anything in this PR which only modifies the Meson build description could possibly cause this (unless you do a silent meson build under the hood from the autotools test hooks, which I don't think you do afaict).

Is the patching causing the build to be static by default? Is this the common convention?

The patch doesn't change whether the lib is built statically or dynamically by default in meson, it just makes sure that if it was configured to be built statically then consumers of the meson dependency (that consume fribidi as a meson subproject) get the right defines passed for the static build config. On Windows this matters because without that define it will try and do dllexport stuff, which it shouldn't be doing for a static library.

[dov]

Thanks @tp-m . You convinced me. 👍