Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move package.base_path to the main API #216

Closed
ghost opened this issue Jul 3, 2018 · 2 comments
Closed

Move package.base_path to the main API #216

ghost opened this issue Jul 3, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Jul 3, 2018 •
edited by ghost

Hi
Hoping to use package's base_path property to make it easier to find, say, a README.md in uploaded datapackage in datapackager..
I note though that the property mentions its use is deprecated?
Any chance this warning was meant just for default_base_path?
Just want to make sure I'm using the right reference. Thanks in advance.
@ghost ghost mentioned this issue Jul 3, 2018
Open
@roll roll changed the title base Move package.base_path to main API Jul 3, 2018
@roll
Copy link
Member

roll commented Jul 3, 2018 •
edited

@mattRedBox
It was deprecated as a part of API simplification.

Because there is a clear use case (frictionlessdata/ckanext-datapackager#60) let's move it to the main API.

Anyway, you can safely use it while it exists in actual API and we have this issue. Or PR if you'd like

@roll roll changed the title Move package.base_path to main API Move package.base_path to the main API Jul 3, 2018
@roll
Copy link
Member

roll commented Jul 4, 2018

Fixed by #217

Release is blocked by frictionlessdata/specs#616

@roll roll closed this as completed Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roll