Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment inside resource/types.py causing mypy to fail #1563

Closed
eliashenko opened this issue Jul 12, 2023 · 2 comments
Closed

Comment inside resource/types.py causing mypy to fail #1563

eliashenko opened this issue Jul 12, 2023 · 2 comments
Assignees
@roll
Labels
bug Something isn't working

Comments

@eliashenko
Copy link

Overview

It is similar to already fixed issue #1561, but now it's in different place 馃槄. Are there any more of these in the codebase?

mypy check for a project that uses frictionless fails with the error:

/site-packages/frictionless/resource/types.py:14:15: error: invalid syntax [syntax]

frictionless version: 5.15.0
mypy version: 1.4.1

Temporal workaround:
Use frictionless==5.13.1 for now
@roll roll added the bug Something isn't working label Jul 17, 2023
@roll
Copy link
Member

roll commented Jul 17, 2023 •
edited

Thanks for reporting!

That's super weird as those are pretty valid comments. I guess they might have some special meaning for mypy. @shashigharti can you please investigate?

@roll roll assigned roll and unassigned shashigharti Jul 31, 2023
@roll roll closed this as completed in 54d05ab Jul 31, 2023
@roll
Copy link
Member

roll commented Jul 31, 2023 •
edited

Hi @eliashenko,

We removed those comments causing mypy to fail but in-general it doesn't pass mypy for now as it's configured for pyright as a static type checker. I created an issue for it #1575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roll roll

Labels
bug Something isn't working
Projects
Open Knowledge
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@roll @shashigharti @eliashenko