RangeDetails: don't return dangling pointers #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenukk
reviewed
Jan 7, 2024
| } else { | ||
| Some(unsafe { | ||
| Self { | ||
| path: CStr::from_ptr((*file).path).to_str().unwrap(), |
There was a problem hiding this comment.
Will the path variable live long enough/not be freed at some point as well? Maybe a clone() here or even to_string_lossy would be safer?
There was a problem hiding this comment.
Fixed.
@domenukk To my eyes, the MemoryRange does not need special treatment, as its from_raw dereferences the pointer into a copy of the object. Correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #120