Fix cargo-xwin build by using CARGO_CFG_TARGET_OS env var instead of #[cfg(target_os = "x")
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Likewise, but I wonder what happened to the checks here... can you maybe push another commit to re-run the CI? |
Problem is it 404s in some packages. Me committing somethings won't change anything, as I see that you tried to re-run the jobs Maybe something's wrong? |
|
I've fixed CI in #97. Once it's merged, you can rebase and we can merge this. |
|
If you rebase CI should be passing. Thanks. |
|
just fixed the formatting |
meme
approved these changes
May 30, 2023
|
@meme can you please cut a version with this change? |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To my surprise something is wrong with the
#[cfg(target_os = "whatever")]. My journey started when I tried to build my project that uses thefridacrate usingcargo-xwin- I wanted to cross-compile it from a linux host to targetx86_64-pc-windows-msvc. When I did that the linker nagged that it couldn't findpthread.libandresolv.lib- which are not windows libraries. They shouldn't be required. The problem was that for some reason thetarget_osvalue was not set according to the target but rather according to the hostI THINK it's due to the
build.rsbeing targeted to the host (as it's the build script).Some useful links:
If this gets merged can we get a new patch release please?