Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with prompt-toolkit 2 #10

Closed
ChiChou opened this issue Nov 23, 2018 · 1 comment
Closed

Incompatible with prompt-toolkit 2 #10

ChiChou opened this issue Nov 23, 2018 · 1 comment

Comments

@ChiChou
Copy link
Contributor

ChiChou commented Nov 23, 2018

prompt-toolkit has breaking change:
(like this: jupyter/jupyter_console#158)

$ frida Finder
Traceback (most recent call last):
  File "/usr/local/bin/frida", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.7/site-packages/frida_tools/repl.py", line 23, in main
    from prompt_toolkit.shortcuts import create_prompt_application, create_output, create_eventloop
ImportError: cannot import name 'create_prompt_application' from 'prompt_toolkit.shortcuts' (/usr/local/lib/python3.7/site-packages/prompt_toolkit/shortcuts/__init__.py)

For those who has encountered same problem, you can temporary downgrade by pip3 install 'prompt-toolkit==1.0.15'

@oleavr
Copy link
Member

oleavr commented Nov 23, 2018

That's intentional if you look at setup.py:

prompt-toolkit >= 0.57, < 2.0.0

Due to lack of time I didn't get around to upgrading to the latest. PR welcome!

@oleavr oleavr closed this as completed Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants