Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Dependencies on shared_preferences #5

Closed
developerspikaway opened this issue Mar 13, 2019 · 5 comments
Closed

[Question] Dependencies on shared_preferences #5

developerspikaway opened this issue Mar 13, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@developerspikaway
Copy link

Hi Frideos,

Why the dependency to shared_preference? This dependency will create problems as there are pods and Android packages behind this (unless mistaken).... I would strongly encourage you to split the implementation that depends on it to another package... frideos is something that could make send to other framework (dart web, backend... ) That might not support shared preferences... What do you think?

Alex.

@frideosapps
Copy link
Owner

Hello. This library was initially conceived for Flutter only but I could take in consideration to maintain this and create a new package without the widgets and SharedPreferences to be used with dart web. Do you think this can be useful? If the SharedPreferences dependency causes issues I can definitely remove it and make an independent package with the helper class.

@AlexandreRoba
Copy link

AlexandreRoba commented Mar 14, 2019

Hi @frideosapps sorry I was using my technical account when I posted the question. So yes for me it would make great sens to split everything which stream/bloc related and Shared preferences which is more phone storage helper. I cannot migrate as I have dependecies that depends on older version of the shared preferences... :(

If you could do it that would be awsome :)

@frideosapps
Copy link
Owner

The simplest solution could be to let this package as it is, like a sort of an all in one package, and publish the three parts, the dart part (let's say frideos_core/dart), widgets (frideos_flutter) and sharedpreferences (frideos_utils) as new packages, in order to minimize dependencies and issues with other packages. I'm not quite sure it is worth the pain to make a package just for the shared preferences helper class but I'll think about it.

@developerspikaway
Copy link
Author

developerspikaway commented Mar 14, 2019 via email

@frideosapps frideosapps added the enhancement New feature or request label Mar 15, 2019
@frideosapps
Copy link
Owner

Hello,
I've just released the new packages:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants