New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Dependencies on shared_preferences #5
Comments
Hello. This library was initially conceived for Flutter only but I could take in consideration to maintain this and create a new package without the widgets and SharedPreferences to be used with dart web. Do you think this can be useful? If the SharedPreferences dependency causes issues I can definitely remove it and make an independent package with the helper class. |
Hi @frideosapps sorry I was using my technical account when I posted the question. So yes for me it would make great sens to split everything which stream/bloc related and Shared preferences which is more phone storage helper. I cannot migrate as I have dependecies that depends on older version of the shared preferences... :( If you could do it that would be awsome :) |
The simplest solution could be to let this package as it is, like a sort of an all in one package, and publish the three parts, the dart part (let's say frideos_core/dart), widgets (frideos_flutter) and sharedpreferences (frideos_utils) as new packages, in order to minimize dependencies and issues with other packages. I'm not quite sure it is worth the pain to make a package just for the shared preferences helper class but I'll think about it. |
Agreed :)
…On Thu, Mar 14, 2019 at 2:59 PM Francesco Mineo ***@***.***> wrote:
The simplest solution could be to let this package as it is, like a sort
of an all in one package, and publish the three parts, the dart part (let's
say frideos_core/dart), widgets (frideos_flutter) and sharedpreferences
(frideos_utils) as new packages, in order to minimize dependencies and
issues with other packages. I'm not quite sure it is worth the pain to make
a package just for the shared preferences helper class but I'll think about
it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AtBp4OVFj-sDJlMprT5nBGSJDhC-Nwg9ks5vWlXRgaJpZM4btYyR>
.
--
*Alexandre Roba*
*CTO*
Pikaway s.a. | Belgium
Mobile: +32 473 29 30 80
Twitter: *@AlexandreRoba* <https://twitter.com/alexandreroba> | Github:
*alexandreroba* <https://github.com/alexandreroba> | Linkedin:
*alexandreroba* <https://www.linkedin.com/in/alexandreroba/> | Keybase:
*844067ED5C2BC060* <https://keybase.io/alexandreroba>
--
DISCLAIMER : The content of this e-mail message does not constitute a
commitment of S.A. Pikaway N.V. or its subsidiaries/affiliates. This e-mail
and any attachments thereto may contain information which is confidential
and/or protected by intellectual property rights and are intended for the
intended recipient only. Any use of the information contained herein
(including, but not limited to, total or partial reproduction,
communication or distribution in any form) by persons other than the
designated recipient(s) is prohibited. If an addressing or transmission
error has misdirected this e-mail, please notify the author, either by
telephone or by e-mail and delete the material from any computer.
|
Hello, |
Hi Frideos,
Why the dependency to shared_preference? This dependency will create problems as there are pods and Android packages behind this (unless mistaken).... I would strongly encourage you to split the implementation that depends on it to another package... frideos is something that could make send to other framework (dart web, backend... ) That might not support shared preferences... What do you think?
Alex.
The text was updated successfully, but these errors were encountered: