Let the user choose a custom heap on the wrapper script. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit, the user can define MIRTRACE_HEAP_ALLOCATION="8GB" to let the mirtrace wrapper script know that it should use that amount of RAM for the JVM heap. The default (when MIRTRACE_HEAP_ALLOCATION is not defined) is to use half of the RAM as before.
|
Thank you for your patch! I think it's a good solution. Sorry about the delay in merging. At some point later on I will release an updated build with this update included. |
|
Looking forward to the next release! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your work :-)
With this commit, the user can define an environment variable
MIRTRACE_HEAP_ALLOCATION="8GB"tolet the mirtrace wrapper script know that it should use that amount of
RAM for the JVM heap.
The default (when MIRTRACE_HEAP_ALLOCATION is not defined) is to use
half of the RAM as before.
I chose to use an environment variable instead of an argument because arguments are passed over to the java subprocess and filtering them would increase complexity.