This repository has been archived by the owner on Oct 3, 2021. It is now read-only.
Various improvements #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MrPetovan
commented
May 8, 2018
•
MrPetovan
commented
- Renamed "plugin" to "addon"
- Added ping during probe (related to Server health tests are a little unfair due to absolute timing values #43)
- Added CLI console
- Added auto increment id field to sync-push-queue (workaround for Feedback loop between multiple servers with push enabled #50)
- Reworked tag table to improve performances
- Fix bunch of PHP Notices
- Fix version check (Update Version Check, including partical automation #49)
added 12 commits
April 3, 2018 20:49
- Add pear/Net_Ping - Add asika/simple-console - Fix composer.json formatting
- Fix App to be used in CLI mode
- Add Config command - Add Probe command - Add PoToPhp command - Remove po2php script
- Add a couple of fields in site-probe
- Remove auto increment id - Replaced nurl by profile id - Added primary key on the two remaining columns
- Add auto increment id to sync-push-queue table to add new profile urls at the end - Use REPLACE instead of INSERT to prevent unique key errors
tobiasd
reviewed
May 8, 2018
src/Core/Console/Config.php
Outdated
| <?php | ||
|
|
||
| /* | ||
| * To change this license header, choose License Headers in Project Properties. |
There was a problem hiding this comment.
Totally, this is added by my IDE and has no business in the repo.
|
Can this be merged soon? |
|
Thanks. |
|
You're welcome, I just found this back since I'm fixing a host of PHP 7 Warnings. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.