Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mailstream] various modernisations #1354

Merged
merged 5 commits into from Apr 1, 2023

Conversation

mexon
Copy link

@mexon mexon commented Apr 1, 2023

  • Remove unused "cron" hook
  • Add "App" arguments to hooks where that is one of the arguments
  • Replace "getHost" with "getHostname"
  • Allow items with an empty plink
  • Remove "ANNOUNCE" items
  • Use baseUrl()->get() instead of baseUrl()
  • Remove in-place modification in mailstream_html_wrap
  • Tweaks to logging

* Remove unused "cron" hook
* Add "App" arguments to hooks where that is one of the arguments
* Replace "getHost" with "getHostname"
* Allow items with an empty plink
* Remove "ANNOUNCE" items
* Use baseUrl()->get() instead of baseUrl()
* Remove in-place modification in mailstream_html_wrap
* Tweaks to logging
@mexon
Copy link
Author

mexon commented Apr 1, 2023

Could someone remind me how to update translation files? I added one translatable string, "URI". The translation, into every human language known, should read "URI" 😉

@MrPetovan
Copy link
Collaborator

Please run bin/run_xgettext.sh -a mailstream from the base Friendica folder.

@mexon
Copy link
Author

mexon commented Apr 1, 2023

Please run bin/run_xgettext.sh -a mailstream from the base Friendica folder.

Done, thanks for the reminder!

mailstream/lang/C/messages.po Outdated Show resolved Hide resolved
mailstream/lang/C/messages.po Outdated Show resolved Hide resolved
mailstream/lang/C/messages.po Outdated Show resolved Hide resolved
Copy link
Collaborator

@nupplaphil nupplaphil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small logging improvements :)

mailstream/mailstream.php Outdated Show resolved Hide resolved
mailstream/mailstream.php Outdated Show resolved Hide resolved
mailstream/mailstream.php Outdated Show resolved Hide resolved
@nupplaphil nupplaphil changed the title Various modernisations to mailstream plugin: [mailstream] various modernisations Apr 1, 2023
mexon and others added 3 commits April 1, 2023 16:41
Co-authored-by: Philipp <admin+Github@philipp.info>
Co-authored-by: Philipp <admin+Github@philipp.info>
Co-authored-by: Philipp <admin+Github@philipp.info>
@MrPetovan MrPetovan merged commit 8c4a61c into friendica:develop Apr 1, 2023
2 checks passed
friendica pushed a commit that referenced this pull request Apr 23, 2023
friendica pushed a commit that referenced this pull request Apr 27, 2023
These changes where made on github as #1354 but got lost due mirroring
issued from the development branch. Original author is mexon.

#1354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants