Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateGServer checks servers that are blocked. #12601

Closed
atasingorneq opened this issue Jan 2, 2023 · 3 comments · Fixed by #12615
Closed

UpdateGServer checks servers that are blocked. #12601

atasingorneq opened this issue Jan 2, 2023 · 3 comments · Fixed by #12615
Assignees
Labels
Milestone

Comments

@atasingorneq
Copy link

  • [x ] I have searched open and closed issues for duplicates

Bug Description

UpdateGServer checks servers that are blocked.

The server *.activitypub-troll.cf is blocked on my instance, but still it is checked by UpdateGServer.

This is what the entry in the worker queue looks like:
56497884 UpdateGServer https://2cjt1orib.activitypub-troll.cf 2023-01-02 18:59:16 40

Steps to Reproduce

  1. Block a server
  2. Wait for UpdateGServer to be executed
  3. Check the worker queue

Actual Result:

The blocked server is checked

Expected Result:

The blocked server should not be checked.

Platform Info

Friendica Version: Friendica 'Giant Rhubarb' 2023.03-dev - 1507

Friendica Source: git

PHP version: 8.1.

@MrPetovan MrPetovan self-assigned this Jan 2, 2023
@MrPetovan MrPetovan added this to the 2023.03 milestone Jan 2, 2023
@annando
Copy link
Collaborator

annando commented Jan 3, 2023

When we pick up the same mechanism like some PR before, where you created an Add function in the corresponding worker class? There we could perform the check for blocked domains. Same can then be applied for UpdateContact as well, where we should check for globally blocked accounts and accounts of blocked domains.

@MrPetovan
Copy link
Collaborator

Yes, ha ha ha, yes!

@mama21mama
Copy link

The same happens to me. but yesterday I did the blocking. but no effect. there are no such domains.

https://reisub.nsupdate.info/filehost/files/6nn.jpg
https://reisub.nsupdate.info/filehost/files/5cW.jpg

the lock doesn't work. they keep making flood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants