Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings of advanced content filter is an empty page. #5341

Closed
rebeka-catalina opened this issue Jul 9, 2018 · 11 comments
Closed

Settings of advanced content filter is an empty page. #5341

rebeka-catalina opened this issue Jul 9, 2018 · 11 comments
Milestone

Comments

@rebeka-catalina
Copy link

Expected behavior

There should be text fields and/or switches/options, something.

Actual behavior

The page is empty and it's not possible to do anything.

Steps to reproduce the problem

I just have to open the page via /addon

Friendica version you encountered the problem

I don't know the friendica version, but to me the advanced content filter behaved this way since the advanced content filter appeared.

see example.com/friendica on your Friendica node for the version information.
current develop

Friendica source (git, zip)

git

PHP version

5.6.36-0+deb8u1

SQL version

10.0.35-MariaDB

@MrPetovan
Copy link
Collaborator

I just tested, the advanced content filter page is still working as of commit e84c48b dating from June 20th 2018.

@rebeka-catalina
Copy link
Author

rebeka-catalina commented Jul 9, 2018 via email

@MrPetovan
Copy link
Collaborator

The advanced content filter setting page is a Javascript Vue app, do you have any error in the browser console?

@rebeka-catalina
Copy link
Author

rebeka-catalina commented Jul 9, 2018 via email

@MrPetovan
Copy link
Collaborator

Okay thanks, this is helpful. So we should either relax the Content Security Policy or avoid eval calls.

@rebeka-catalina
Copy link
Author

rebeka-catalina commented Aug 2, 2018 via email

@MrPetovan
Copy link
Collaborator

I found that Vue templates can be compiled in advance, which would avoid eval() calls and pass the CSP block.

@rebeka-catalina
Copy link
Author

rebeka-catalina commented Aug 4, 2018 via email

@MrPetovan
Copy link
Collaborator

Great, that was the point! I probably am the only that can change the display of the addon settings from now on, but at least it's working for you!

@rebeka-catalina
Copy link
Author

rebeka-catalina commented Aug 5, 2018 via email

@MrPetovan
Copy link
Collaborator

I'm available for all your questions. The addon is intended to be generic and expose as much data from items as possible, which can be confusing indeed.

Here are my own rules:

  • "Mastodon Sensitive Image": content_warning && network == 'stat' && body matches "/\\[img\\]/"
  • "NSFW": body matches "/\\]#NSFW\\[/i"
  • "NSFW image": body matches "/nsfw/i" and body matches "/\\[img/"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants