Move global functions from include/ to class methods in src/

[annando]

We already are having some files in /include that are containing classes that we could move without a problem to /src.

This includes diaspora.php, dfrn.php and ostatus.php and possibly some more.

Tracking document: https://ethercalc.org/friendica_classes

Please update it with your planned changes.

Per @MrPetovan

So that everything is clear: in Model should only be static classes that interact with the DB with the same name as a database table.
In Object should be all the support classes that don't interact with any database table and shouldn't have the same name as a database table.

Remaining files:

• api.php (needs proper router first)
• conversation.php
• dba.php (covered by Move include/dba.php to src/ #5410)
• enotify.php
• items.php (Remove include/items.php #8880)
• security.php (Move and Split include/security #5946)
• text.php (Move include/text.php to src/Content/Text #6042)

[MrPetovan]

@zeroadam expressed his interest in working on this issue.

[annando]

So now we should collect a list of files and their best class paths.

[MrPetovan]

Periodic reminder: https://ethercalc.org/friendica_classes

[annando]

Currently we cannot move every file on that list. the dba.php and Photo.php for example do contain class methods and normal functions. We had to split them before moving them.

Files where it should work are:

• dbm.php
• dfrn.php
• diaspora.php
• NotificationsManager.php

Attention:
If these are moved, then they need a use dba;and use dbm; as well, if these class methods are used in the files.

But if dbm.php is moved, then the use dbm; in all files under src has to be changed to the full path as well.

[MrPetovan]

PHP Fatal error: Uncaught Error: Class 'Friendica\Protocol\Crypto' not found in src/Protocol/DFRN.php:1299

I'm on it.

[annando]

Next files could be:

• cache.php
• DirSearch.php
• Emailer.php
• ForumManager.php
• Smilies.php
• xml.php

Relocating these should be less harder, since they aren't as much included as dbm.php.

[zeroadam]

So, will this issue stay open for all future include/ to src/ work to reference?

[MrPetovan]

Indeed, and already a big thank you for your work, it's much appreciated!

[zeroadam]

Absolutely welcome! Glad to finally be able to start contributing, and glad to continue to do so!!!

[annando]

You make @MrPetovan very happy with this work.

[MrPetovan]

So happy I stay up most of the night to track fatal errors with a third-party library! 😅

(I truly am happy)

[rabuzarus]

BTW: If someone has time and is very motivated; the method names in classes should be renamed to camelCase.
e.g. DBM::isResult( ) (instead of DBM::is_result( ))

[annando]

@rabuzarus I suggest that we are doing this after we moved all possible classes to /src. Then someone can have a look at the method under this folder and can clean this up.

[zeroadam]

I was also noticing this, but figured @annando wouldn't want all these changes in this particular work.

[rabuzarus]

Just thought, while breaking addon for friendica master, we should also rename the method names in this develop cycle. So we don't need to break it again in the next cycle.
But this was meant as suggestion.

[nupplaphil]

This one is finished, yipeah! :-)