-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New traceback formatting with stack_data #38
Comments
aroberge
added a commit
that referenced
this issue
Aug 31, 2022
aroberge
added a commit
that referenced
this issue
Aug 31, 2022
aroberge
added a commit
that referenced
this issue
Aug 31, 2022
aroberge
added a commit
that referenced
this issue
Aug 31, 2022
aroberge
added a commit
that referenced
this issue
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See friendly-traceback/friendly-traceback#152
Note: some statements like
used to be entirely highlighted. However, after working on issue 152 mentioned above, with the latest version using
stack_data
, they are no longer highlighted. This is ok forfriendly_traceback
, but with the coloured highlighting provided byfriendly
, it makes sense to highlight them.Tasks:
friendly_traceback
After
friendly_traceback
has been updatedfriendly
compatible with this newest versionraise LookupError("Fake message")
mentioned above, would still be highlighted. The key here is to look for a line indicator,-->
, with no corresponding^
markers. Edit With the new hihglighting of the line number itself, it does not seem necessary to highlight the entire text; in fact, it would be less attractive to do so.UseMy revised version likely works better as the contrast is guaranteed.Rich
's addition for "partial highlights" (need a reference here) to replace my current custom code for background highlighting.The text was updated successfully, but these errors were encountered: