Allow removal of category only when no items

Only remove category when there are no items inside the category
friends-of-forkcms · Feb 16, 2015 · 5ac1806 · 5ac1806
1 parent f96e5eb
commit 5ac1806
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 3 deletions.
diff --git a/src/Backend/Modules/Menu/Actions/EditCategory.php b/src/Backend/Modules/Menu/Actions/EditCategory.php
@@ -75,6 +75,10 @@ protected function parse()
 
         // assign the data
         $this->tpl->assign('item', $this->record);
+
+        if (BackendMenuModel::getItemsInCategory($this->record['id']) == 0) {
+            $this->tpl->assign('emptyCategory', true);
+        }
     }
 
     /**

diff --git a/src/Backend/Modules/Menu/Engine/Model.php b/src/Backend/Modules/Menu/Engine/Model.php
@@ -76,12 +76,12 @@ public static function deleteAlacarte($id)
     public static function deleteCategory($id)
     {
         $db = BackendModel::get('database');
-        $item = self::getCategory($id);
+        $item = self::existsCategory($id);
 
         if (!empty($item)) {
             $db->delete('meta', 'id = ?', array($item['meta_id']));
             $db->delete('menu_categories', 'id = ?', array((int) $id));
-            $db->update('menu', array('category_id' => null), 'category_id = ?', array((int) $id));
+            $db->update('menu_alacarte', array('category_id' => null), 'category_id = ?', array((int) $id));
         }
     }
 
@@ -460,4 +460,20 @@ public static function updateCategory(array $item)
             'menu_categories', $item, 'id = ?', array($item['id'])
         );
     }
+
+    /**
+     * Get the number of items in a category
+     *
+     * @param $categoryId
+     * @return int Number of items in category
+     */
+    public static function getItemsInCategory($categoryId)
+    {
+        return (int) BackendModel::get('database')->getVar(
+            'SELECT COUNT(*)
+            FROM menu_alacarte
+            WHERE category_id = ?',
+            array((int) $categoryId)
+        );
+    }
 }
diff --git a/src/Backend/Modules/Menu/Installer/Data/locale.xml b/src/Backend/Modules/Menu/Installer/Data/locale.xml
@@ -69,6 +69,10 @@
 				<translation language="en"><![CDATA[no categories]]></translation>
 				<translation language="nl"><![CDATA[geen categorieën]]></translation>
 			</item>
+			<item type="message" name="EmptyCategoriesFirst">
+				<translation language="en"><![CDATA[Verwijder alle gerechten in de categorie voordat u deze kunt verwijderen.]]></translation>
+				<translation language="nl"><![CDATA[Remove all the dishes in the category before you can remove this.]]></translation>
+			</item>
 		</Core>
 	</Backend>
 	<Frontend>

diff --git a/src/Backend/Modules/Menu/Layout/Templates/Categories.tpl b/src/Backend/Modules/Menu/Layout/Templates/Categories.tpl
@@ -14,7 +14,7 @@
         {$dataGrid}
     </div>
 {/option:dataGrid}
-{option:!dataGrid}{$msgNoCategories}{/option:!dataGrid}
+{option:!dataGrid}{$msgNoCategories|ucfirst}{/option:!dataGrid}
 
 {include:{$BACKEND_CORE_PATH}/Layout/Templates/StructureEndModule.tpl}
 {include:{$BACKEND_CORE_PATH}/Layout/Templates/Footer.tpl}
diff --git a/src/Backend/Modules/Menu/Layout/Templates/EditCategory.tpl b/src/Backend/Modules/Menu/Layout/Templates/EditCategory.tpl
@@ -29,6 +29,7 @@
     </div>
 
     <div class="fullwidthOptions">
+        {option:emptyCategory}
         <a href="{$var|geturl:'delete_category'}&amp;id={$item.id}" data-message-id="confirmDelete" class="askConfirmation button linkButton icon iconDelete">
             <span>{$lblDelete|ucfirst}</span>
         </a>
@@ -37,6 +38,10 @@
                 {$msgConfirmDeleteCategory|sprintf:{$item.title}}
             </p>
         </div>
+        {/option:emptyCategory}
+        {option:!emptyCategory}
+            {$msgEmptyCategoriesFirst|ucfirst}
+        {/option:!emptyCategory}
 
         <div class="buttonHolderRight">
             <input id="editButton" class="inputButton button mainButton" type="submit" name="edit" value="{$lblSave|ucfirst}" />