Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Require phpunit/phpunit:^9.5.20 #229

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

localheinz
Copy link
Collaborator

This pull request

  • requires phpunit/phpunit:^9.5.20

πŸ’β€β™‚οΈ It supports PHP 7.3 onwards, so there is no need to use phpunit/phpunit:^8.0.0.

@localheinz localheinz self-assigned this Apr 28, 2022
@localheinz localheinz merged commit a8b62a9 into friendsoftwig:main Apr 28, 2022
@localheinz localheinz deleted the fix/phpunit branch April 28, 2022 09:35
@Ciloe
Copy link
Collaborator

Ciloe commented Apr 28, 2022

A lot of PR for one file. Maybe you can do it in one PR in the futur ? @localheinz

@localheinz
Copy link
Collaborator Author

@Ciloe

I am working on a book (see https://leanpub.com/working-with-pull-requests) where I will explain why that is not a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants