Implement twigcs as a single command application #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check failing tests :) |
|
I opened https://github.com/allocine/twigcs/pull/41 to fix the test suite. This PR is not related to the test failure. |
OwlyCode
approved these changes
Jul 16, 2018
Ciloe
approved these changes
Jul 16, 2018
|
The fix got merged, can you rebase it and also update the README for the usage instructions ? |
|
Tests passed. |
|
Thank you for your contribution ! |
Cerzat43
added a commit
to Cerzat43/vscode-twigcs
that referenced
this pull request
Aug 28, 2020
close #20 Since the release v3.1.0, twigcs is a single command application : * The release : https://github.com/friendsoftwig/twigcs/releases/tag/v3.1.0 * The commit : friendsoftwig/twigcs#40 We have to remove the `lint` parameter in the command line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
twigcs by its nature is a single command application. So having to call
lintcommand explicitly seems redundant.