Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change sign status (±) when a habit already exist #64

Closed
serrq opened this issue Jul 19, 2023 · 4 comments · Fixed by #67
Closed

Cannot change sign status (±) when a habit already exist #64

serrq opened this issue Jul 19, 2023 · 4 comments · Fixed by #67
Labels
bug Something isn't working

Comments

@serrq
Copy link

serrq commented Jul 19, 2023

(Positive/Negative) Sign switch doesn't work when a habit already exist.

TH 1.8.0
Android 13
OnePlus CPH2399

1000035206

@FriesI23
Copy link
Owner

This is part of the design (in future, different habit types may have incompatible features).
However, it seems not very user-friendly for existing habits. I will address this limitation in the next version. But in future releases, it may still be impossible to change the type of existing habits (depending on whether there are any newly added incompatible features).

@FriesI23 FriesI23 added the bug Something isn't working label Jul 20, 2023
@FriesI23
Copy link
Owner

FriesI23 added a commit that referenced this issue Jul 20, 2023
- fixed positive habit's daily goal set to 0 problem in edit page
- fixed unable to switch habitType when editting exsit habit

see #64, #66 on github
FriesI23 added a commit that referenced this issue Jul 20, 2023
- fixed positive habit's daily goal set to 0 problem in edit page
- fixed unable to switch habitType when editting exsit habit

see #64, #66 on github
@serrq
Copy link
Author

serrq commented Jul 20, 2023

In future releases, it may still be impossible to change the type of existing habits (depending on whether there are any newly added incompatible features).

Popup (bottom notification toast) with small explanation? (When one tries to switch sign on incompatible future habits)

For example: "This action is not allowed with this type of habit. Create a new one."

Is it an exaggeration or can it help less experienced users?

@FriesI23
Copy link
Owner

Popup (bottom notification toast) with small explanation? (When one tries to switch sign on incompatible future habits)

For example: "This action is not allowed with this type of habit. Create a new one."

I agreed, if change where not allowed, there should be a snackbar popped. However, I removed limit in last release (and also fixed some bugs).

Thank you very much for your suggestion.😘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants