New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #193, allow loading root and child apps asynchronously #206
Conversation
58289b0
to
1c6e84b
Compare
Refs #193 |
This is really cool, @reaktivo! 💖 |
@alexmiranda @fahad19 What do you guys think about not exposing the root app global when in production environments? |
@reaktivo: can you please explain further? I am curious how we can register other Apps being loaded from separate bundles. |
@fahad19 The idea was this: https://gist.github.com/reaktivo/7709df18e800ca35f4bcedaaaa4aec66 but then I thought it doesn't make any sense, any developer with access to a debugger could access the root app instance if they wanted to anyway. |
@reaktivo: 👍 btw, are you planning to write a new page in this PR under the |
@fahad19 Yes, it's coming. |
@reaktivo: we are planning to release a new 1.x version, before we gear up for 2.x with latest React. any chance this PR can be merged soon so it goes into 1.x? |
@fahad19 @alexmiranda Any comments on this PR? |
@reaktivo: lgtm 👍 |
LGTM. 👍 |
Not actually a feature, but updated the Multiple Apps example to show how a developer might implement asynchronous loading and execution of apps. This allows the browser to download multiple apps in parallel and for the possibility of the root app to load after any child app.