Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #193, allow loading root and child apps asynchronously #206

Merged
merged 5 commits into from Jul 17, 2017

Conversation

reaktivo
Copy link
Contributor

Not actually a feature, but updated the Multiple Apps example to show how a developer might implement asynchronous loading and execution of apps. This allows the browser to download multiple apps in parallel and for the possibility of the root app to load after any child app.

@reaktivo reaktivo force-pushed the feature-193-allow-async-loading-apps branch from 58289b0 to 1c6e84b Compare May 26, 2017 15:52
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.363% when pulling 1c6e84b on feature-193-allow-async-loading-apps into 032a557 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.363% when pulling 1c6e84b on feature-193-allow-async-loading-apps into 032a557 on master.

@fahad19
Copy link
Member

fahad19 commented May 26, 2017

Refs #193

@fahad19
Copy link
Member

fahad19 commented May 26, 2017

This is really cool, @reaktivo! 💖

@reaktivo
Copy link
Contributor Author

@alexmiranda @fahad19 What do you guys think about not exposing the root app global when in production environments?

@fahad19
Copy link
Member

fahad19 commented May 27, 2017

@reaktivo: can you please explain further? I am curious how we can register other Apps being loaded from separate bundles.

@reaktivo
Copy link
Contributor Author

@fahad19 The idea was this: https://gist.github.com/reaktivo/7709df18e800ca35f4bcedaaaa4aec66 but then I thought it doesn't make any sense, any developer with access to a debugger could access the root app instance if they wanted to anyway.

@fahad19
Copy link
Member

fahad19 commented May 29, 2017

@reaktivo: 👍

btw, are you planning to write a new page in this PR under the How TOs section here for async loading? https://frint.js.org/guides/

@reaktivo
Copy link
Contributor Author

@fahad19 Yes, it's coming.

@fahad19 fahad19 added the PR label May 29, 2017
@fahad19
Copy link
Member

fahad19 commented Jun 14, 2017

@reaktivo: we are planning to release a new 1.x version, before we gear up for 2.x with latest React.

any chance this PR can be merged soon so it goes into 1.x?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 97.375% when pulling b5d3abb on feature-193-allow-async-loading-apps into 032a557 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.375% when pulling abf114a on feature-193-allow-async-loading-apps into 4870a20 on master.

@reaktivo
Copy link
Contributor Author

@fahad19 @alexmiranda Any comments on this PR?

@fahad19
Copy link
Member

fahad19 commented Jul 17, 2017

@reaktivo: lgtm 👍

@reaktivo reaktivo merged commit 26f4897 into master Jul 17, 2017
@alexmiranda
Copy link
Contributor

LGTM. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants